Skip to content

Commit f818e51

Browse files
authored
Merge pull request #198 from esron/nodejs-bump
bump nodejs to next lts
2 parents bb0fda3 + 8409912 commit f818e51

File tree

7 files changed

+11
-8
lines changed

7 files changed

+11
-8
lines changed

.tool-versions

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
nodejs 18.16.1

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM registry.access.redhat.com/ubi8/nodejs-16
1+
FROM registry.access.redhat.com/ubi8/nodejs-18
22

33
USER root
44

Dockerfile.tester

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
FROM registry.access.redhat.com/ubi8/nodejs-16
1+
FROM registry.access.redhat.com/ubi8/nodejs-18
22

33
USER root
4+
ENV CI=1
45

56
# RUN dnf -y update-minimal --security --sec-severity=Important --sec-severity=Critical && \
67
# dnf clean all

Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,6 @@ build-test:
2626

2727
test: build-test
2828
@docker run --rm $(IMAGE_TEST)
29+
30+
dev-docker-run: build
31+
docker run --rm -p 8080:8080 -e AUTHORIZATION=blub -e API_AUTH=blub -e API_URI=https://app-interface.devshift.net -e GRAPHQL_URI=https://app-interface.devshift.net -v $(shell pwd)/public/env:/opt/visual-qontract/build/env $(IMAGE_NAME):latest

README.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,7 @@ It is written in [React](https://reactjs.org/) and uses [PatternFly 3](https://w
88

99
```sh
1010
$ cp public/env/env.js.example public/env/env.js
11-
$ sed -i.bk '/GRAPHQL_URI/d' public/env/env.js
12-
$ docker run --rm -p 8080:8080 \
13-
-e AUTHORIZATION="Basic <TOKEN>" -e GRAPHQL_URI="<URL>" \
14-
-v $PWD/public/env:/opt/visual-qontract/build/env:z \
15-
quay.io/app-sre/visual-qontract:latest
11+
$ make dev-docker-run
1612
```
1713

1814
The visual-qontract UI will be reachable on http://localhost:8080

pr_check.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
#!/bin/bash
22

3+
set -e
4+
35
make test

src/pages/elements/Scorecard.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react';
22
import { Table, ProgressBar } from 'patternfly-react';
3-
import ReactMarkdown from 'react-markdown';
3+
import ReactMarkdown from 'react-markdown/react-markdown.min';
44
import ScorecardData from '../../components/ScorecardData';
55
import Definition from '../../components/Definition';
66

0 commit comments

Comments
 (0)