Downstream native-image embedders are broken
#907
Comments
sgammon
added a commit
to elide-dev/pkl
that referenced
this issue
Jan 28, 2025
- fix: don't exclude svm classes from `cli` jar SVM (SubstrateVM) compile configuration classes must be included within the `cli` jar to prevent downstream `native-image` builds from failing. - fix: include svm exclusions in fatjar config Fat JARs cannot be used with `native-image`, so these classes can still safely be excluded here. Fixes and closes apple#907 Signed-off-by: Sam Gammon <[email protected]>
sgammon
added a commit
to elide-dev/pkl
that referenced
this issue
Jan 28, 2025
- fix: don't exclude svm classes from `cli` jar SVM (SubstrateVM) compile configuration classes must be included within the `cli` jar to prevent downstream `native-image` builds from failing. - fix: include svm exclusions in fatjar config Fat JARs cannot be used with `native-image`, so these classes can still safely be excluded here. Fixes and closes apple#907 Cherry-picked from apple#914 Signed-off-by: Sam Gammon <[email protected]>
sgammon
added a commit
to elide-dev/pkl
that referenced
this issue
Jan 28, 2025
- fix: don't exclude svm classes from `cli` jar SVM (SubstrateVM) compile configuration classes must be included within the `cli` jar to prevent downstream `native-image` builds from failing. - fix: include svm exclusions in fatjar config Fat JARs cannot be used with `native-image`, so these classes can still safely be excluded here. Fixes and closes apple#907 Cherry-picked from apple#914 Signed-off-by: Sam Gammon <[email protected]>
sgammon
added a commit
to elide-dev/pkl
that referenced
this issue
Jan 28, 2025
- fix: don't exclude svm classes from `cli` jar SVM (SubstrateVM) compile configuration classes must be included within the `cli` jar to prevent downstream `native-image` builds from failing. - fix: include svm exclusions in fatjar config Fat JARs cannot be used with `native-image`, so these classes can still safely be excluded here. Fixes and closes apple#907 Cherry-picked from apple#914 Signed-off-by: Sam Gammon <[email protected]>
sgammon
added a commit
to elide-dev/pkl
that referenced
this issue
Jan 29, 2025
- fix: don't exclude svm classes from `cli` jar SVM (SubstrateVM) compile configuration classes must be included within the `cli` jar to prevent downstream `native-image` builds from failing. - fix: include svm exclusions in fatjar config Fat JARs cannot be used with `native-image`, so these classes can still safely be excluded here. Fixes and closes apple#907 Cherry-picked from apple#914 Signed-off-by: Sam Gammon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pkl/pkl-cli/pkl-cli.gradle.kts
Lines 87 to 88 in 258eda8
This exclusion drops key classes from the
pkl-cliJAR which are needed to build Pkl native binaries. While the comment is correct, these classes are inert for JVM use at runtime, embedders will Have A Bad Time if these classes are excluded from anative-imageclasspath downstream, when using thepkl-cli-*JAR.These classes can be dropped from fat JARs, because shading with Truffle is only supported on JVM anyway.
The text was updated successfully, but these errors were encountered: