Skip to content

Commit daa0ab4

Browse files
committed
. e Fix Java 8 compatibility for maven builds and GitHub actions
- Skip install for test-only module approvaltests-util-tests - Generate Maven 3.8.8 wrapper in GitHub action for Java 8 compatibility - Use wrapper instead of system Maven to avoid plugin version conflicts
1 parent e148a6f commit daa0ab4

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

.github/workflows/test-jdk-8.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,15 @@ jobs:
3939
- name: Use local build
4040
run: |
4141
sed -i '/<artifactId>approvaltests<\/artifactId>/{N;s/<version>.*<\/version>/<version>100.0.0-SNAPSHOT<\/version>/}' pom.xml
42+
- name: Setup Maven Wrapper for Java 8 compatibility
43+
run: |
44+
mvn wrapper:wrapper -Dmaven=3.8.8
4245
- name: Run in JDK8
4346
run: |
4447
java -version
45-
mvn verify
48+
./mvnw verify
4649
- name: Publish Test Report
4750
uses: mikepenz/action-junit-report@v5
4851
if: always()
4952
with:
5053
report_paths: '**/target/surefire-reports/*.xml'
51-

approvaltests-util-tests/pom.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -84,14 +84,6 @@
8484
<artifactId>maven-surefire-plugin</artifactId>
8585
<version>3.5.3</version>
8686
</plugin>
87-
<plugin>
88-
<groupId>org.apache.maven.plugins</groupId>
89-
<artifactId>maven-jar-plugin</artifactId>
90-
<version>3.4.2</version>
91-
<configuration>
92-
<skipIfEmpty>true</skipIfEmpty>
93-
</configuration>
94-
</plugin>
9587
</plugins>
9688
</build>
9789

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
# Test module - no main classes

0 commit comments

Comments
 (0)