Skip to content

Commit 6b08d09

Browse files
eldadfuxeldadfux
authored
Merge pull request #74 from appwrite/feat-cleanups
Cleanups
2 parents 5ac78fa + 206958b commit 6b08d09

File tree

7 files changed

+5
-276
lines changed

7 files changed

+5
-276
lines changed

‎CONTRIBUTING.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ docker run --rm --interactive --tty --volume "%cd%":/app composer install
3838
First, create a new class for the new language in this directory:
3939
[/src/SDK/Language](https://github.com/appwrite/sdk-generator/tree/master/src/SDK/Language)
4040

41+
4142
You can use the interface to know which methods are required to be implemented:
4243
[/src/SDK/Language.php](https://github.com/appwrite/sdk-generator/blob/master/src/SDK/Language.php)
4344

‎example.php‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@
1919
use Appwrite\SDK\Language\CSharp;
2020
use Appwrite\SDK\Language\Flutter;
2121

22-
$languages = ['web', 'node', 'php', 'python', 'ruby', 'dart', 'go', 'java', 'swift', 'typescript', 'deno', 'http', 'csharp'];
23-
2422
try {
2523

2624
function getSSLPage($url) {
@@ -195,7 +193,7 @@ function getSSLPage($url) {
195193

196194
$sdk->generate(__DIR__ . '/examples/dart');
197195

198-
// Dart
196+
// Flutter
199197
$sdk = new SDK(new Flutter(), new Swagger2($spec));
200198

201199
$sdk

‎mock/templates/deno.ts‎

Lines changed: 0 additions & 26 deletions
This file was deleted.

‎src/SDK/Language/Dart.php‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,4 +320,3 @@ public function getFiles()
320320
];
321321
}
322322
}
323-

‎src/SDK/Language/Flutter.php‎

Lines changed: 1 addition & 228 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@
22

33
namespace Appwrite\SDK\Language;
44

5-
use Appwrite\SDK\Language;
6-
7-
class Flutter extends Language {
5+
class Flutter extends Dart {
86

97
/**
108
* @var array
@@ -13,17 +11,6 @@ class Flutter extends Language {
1311
'packageName' => 'packageName',
1412
];
1513

16-
/**
17-
* @param string $name
18-
* @return $this
19-
*/
20-
public function setPackageName($name)
21-
{
22-
$this->setParam('packageName', $name);
23-
24-
return $this;
25-
}
26-
2714
/**
2815
* @return string
2916
*/
@@ -32,219 +19,6 @@ public function getName()
3219
return 'Flutter';
3320
}
3421

35-
/**
36-
* Get Language Keywords List
37-
*
38-
* @return array
39-
*/
40-
public function getKeywords()
41-
{
42-
return [
43-
"abstract",
44-
"dynamic",
45-
"implements",
46-
"show",
47-
"as",
48-
"else",
49-
"import",
50-
"static",
51-
"assert",
52-
"enum",
53-
"in",
54-
"super",
55-
"async",
56-
"export",
57-
"interface",
58-
"switch",
59-
"await",
60-
"extends",
61-
"is",
62-
"sync",
63-
"break",
64-
"external",
65-
"library",
66-
"this",
67-
"case",
68-
"factory",
69-
"mixin",
70-
"throw",
71-
"catch",
72-
"false",
73-
"new",
74-
"true",
75-
"class",
76-
"final",
77-
"null",
78-
"try",
79-
"const",
80-
"finally",
81-
"on",
82-
"typedef",
83-
"continue",
84-
"for",
85-
"operator",
86-
"var",
87-
"covariant",
88-
"Function",
89-
"part",
90-
"void",
91-
"default",
92-
"get",
93-
"rethrow",
94-
"while",
95-
"deferred",
96-
"hide",
97-
"return",
98-
"with",
99-
"do",
100-
"if",
101-
"set",
102-
"yield",
103-
];
104-
}
105-
106-
/**
107-
* @param $type
108-
* @return string
109-
*/
110-
public function getTypeName($type)
111-
{
112-
switch ($type) {
113-
case self::TYPE_INTEGER:
114-
return 'int';
115-
break;
116-
case self::TYPE_STRING:
117-
return 'String';
118-
break;
119-
case self::TYPE_FILE:
120-
return 'MultipartFile';
121-
break;
122-
case self::TYPE_BOOLEAN:
123-
return 'bool';
124-
break;
125-
case self::TYPE_ARRAY:
126-
return 'List';
127-
case self::TYPE_OBJECT:
128-
return 'dynamic';
129-
break;
130-
}
131-
132-
return $type;
133-
}
134-
135-
/**
136-
* @param array $param
137-
* @return string
138-
*/
139-
public function getParamDefault(array $param)
140-
{
141-
$type = $param['type'] ?? '';
142-
$default = $param['default'] ?? '';
143-
$required = $param['required'] ?? '';
144-
145-
if($required) {
146-
return '';
147-
}
148-
149-
$output = ' = ';
150-
151-
if(empty($default) && $default !== 0 && $default !== false) {
152-
switch ($type) {
153-
case self::TYPE_OBJECT:
154-
$output .= '{}';
155-
break;
156-
case self::TYPE_NUMBER:
157-
case self::TYPE_INTEGER:
158-
$output .= '0';
159-
break;
160-
case self::TYPE_BOOLEAN:
161-
$output .= 'false';
162-
break;
163-
case self::TYPE_ARRAY:
164-
$output .= '[]';
165-
break;
166-
case self::TYPE_STRING:
167-
$output .= "''";
168-
break;
169-
}
170-
}
171-
else {
172-
switch ($type) {
173-
case self::TYPE_OBJECT:
174-
case self::TYPE_NUMBER:
175-
case self::TYPE_INTEGER:
176-
$output .= $default;
177-
break;
178-
case self::TYPE_ARRAY:
179-
$output .= 'const '.$default;
180-
break;
181-
case self::TYPE_BOOLEAN:
182-
$output .= ($default) ? 'true' : 'false';
183-
break;
184-
case self::TYPE_STRING:
185-
$output .= "'{$default}'";
186-
break;
187-
}
188-
}
189-
190-
return $output;
191-
}
192-
193-
/**
194-
* @param array $param
195-
* @return string
196-
*/
197-
public function getParamExample(array $param)
198-
{
199-
$type = $param['type'] ?? '';
200-
$example = $param['example'] ?? '';
201-
202-
$output = '';
203-
204-
if(empty($example) && $example !== 0 && $example !== false) {
205-
switch ($type) {
206-
case self::TYPE_FILE:
207-
$output .= 'await MultipartFile.fromFile(\'./path-to-files/image.jpg\', \'image.jpg\')';
208-
break;
209-
case self::TYPE_NUMBER:
210-
case self::TYPE_INTEGER:
211-
$output .= '0';
212-
break;
213-
case self::TYPE_BOOLEAN:
214-
$output .= 'false';
215-
break;
216-
case self::TYPE_STRING:
217-
$output .= "''";
218-
break;
219-
case self::TYPE_OBJECT:
220-
$output .= '{}';
221-
break;
222-
case self::TYPE_ARRAY:
223-
$output .= '[]';
224-
break;
225-
}
226-
}
227-
else {
228-
switch ($type) {
229-
case self::TYPE_OBJECT:
230-
case self::TYPE_FILE:
231-
case self::TYPE_NUMBER:
232-
case self::TYPE_INTEGER:
233-
case self::TYPE_ARRAY:
234-
$output .= $example;
235-
break;
236-
case self::TYPE_BOOLEAN:
237-
$output .= ($example) ? 'true' : 'false';
238-
break;
239-
case self::TYPE_STRING:
240-
$output .= "'{$example}'";
241-
break;
242-
}
243-
}
244-
245-
return $output;
246-
}
247-
24822
/**
24923
* @return array
25024
*/
@@ -320,4 +94,3 @@ public function getFiles()
32094
];
32195
}
32296
}
323-

‎src/SDK/SDK.php‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -465,10 +465,8 @@ public function generate($target)
465465
'sdk' => $this->getParams(),
466466
];
467467

468-
foreach ($this->language->getFiles() as $file) { /** @var $file [] */
469-
470-
/* @var $template \Twig\TemplateWrapper */
471-
$template = $this->twig->load($file['template']);
468+
foreach ($this->language->getFiles() as $file) {
469+
$template = $this->twig->load($file['template']); /* @var $template \Twig\TemplateWrapper */
472470
$destination = $target . '/' . $file['destination'];
473471
$block = $file['block'] ?? null;
474472
$minify = $file['minify'] ?? false;

‎src/Spec/OpenAPI3.php‎

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)