Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voting: add more sanity checks to initialization arguments #1057

Closed
sohkai opened this issue Dec 12, 2019 · 1 comment
Closed

Voting: add more sanity checks to initialization arguments #1057

sohkai opened this issue Dec 12, 2019 · 1 comment
Labels
app: voting component: contract

Comments

@sohkai
Copy link
Contributor

sohkai commented Dec 12, 2019 •
edited
Loading

Note: this has been closed to be tracked in the "wishlist for future upgrades".

We should at least be checking that the:

  • Token is a contract
  • Voting time is not 0
@sohkai
Copy link
Contributor Author

sohkai commented Mar 18, 2020

Closing; we will evaluate adding this when we do the next contract upgrade.

@sohkai sohkai closed this as completed Mar 18, 2020
@sohkai sohkai mentioned this issue Mar 18, 2020
Open
@sohkai sohkai mentioned this issue Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app: voting component: contract
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sohkai