-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close #18: Switch policy lang support to V2. #98
base: main
Are you sure you want to change the base?
Conversation
What will the error look like if someone tries to use |
Didn't have that planned but that's a good idea.
I suppose that would be the only option, as we don't plan to support multiple policy lang versions. But using an older VM will probably mean using an older everything else as some of the internal interfaces are evolving as well. |
Do people have opinions on how we want to manage the version change? I wasn't planning on landing all the v2 features at once, so there will be some awkward middle ground as it gets built. My thought was I'd throw up the flag early so the version has to be updated now as features roll out. We could also do it at the end. Policies are going to break either way once block scoping is fully enabled. If we really want it to drop all at once, we could target a feature branch. But I'd rather avoid the PR management hassle if I can. |
we're the primary user of policy right now, so the "rip the bandaid off" approach is probably just fine |
I guess I'm not sure of the reason to do the version change now if we are going to do breaking changes later within in this version. Well, I guess there's not much difference in breaking v1 or v2... |
I figured it was more polite to do this first so people updating |
Good points. The current error message is |
Policy language version 1 is now deprecated, and the parser will error out if it encounters it. Going forward, use
policy-version: 2
in the front matter of policy.md
files.