Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MaxCut a u32 #94

Open
nikki-aranya opened this issue Feb 6, 2025 · 1 comment
Open

Make MaxCut a u32 #94

nikki-aranya opened this issue Feb 6, 2025 · 1 comment

Comments

@nikki-aranya
Copy link
Contributor

nikki-aranya commented Feb 6, 2025

We currently have a MaxCut type that aliases to usize which we shouldn't be sending over the network due to platform incompatibilities, as well as it currently not being public. Instead, let's make it a u32 and refactor our APIs. Let's also double check the places where we use a max_cut but don't use the type (for example in Address).

@jdygert-spok
Copy link
Contributor

Maybe make it a newtype wrapper for a little more type safety and encapsulation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants