make key optional on read policy #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supports generating a policy for buckets too.
Owner
|
Has this worked for you? My understanding of it is that you must specify a complete URL which is then signed. If the URL is variable so you can access anything within the bucket, I don't see how the signature could be validated. I honestly don't have an environment setup where I can test this easily, so if you say it is working for you I'll go ahead and merge it. Thanks. |
main.js
Outdated
unintentionally removed a line...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making the key an optional parameter of readPolicy, we can readPolicy for a bucket too. Very useful to me..