never serialize coordinate

Author: EmrysMyrddin

packages/utils/src/errors.ts

@@ -22,13 +22,6 @@ declare module 'graphql' {
      */
     readonly coordinate?: string;
   }
-
-  interface GraphQLFormattedError {
-    /**
-     * An optional schema coordinate (e.g. "MyType.myField") associated with this error.
-     */
-    readonly coordinate?: string;
-  }
 }
 
 const possibleGraphQLErrorProperties = [
@@ -53,13 +46,6 @@ export function isGraphQLErrorLike(error: any) {
   );
 }
 
-export const toJSON: GraphQLError['toJSON'] = function toJSON(this: GraphQLError) {
-  const formattedError = GraphQLError.prototype.toJSON.apply(this);
-  // @ts-expect-error coordinate is readonly
-  formattedError.coordinate = this.coordinate;
-  return formattedError;
-};
-
 export function createGraphQLError(message: string, options?: GraphQLErrorOptions): GraphQLError {
   if (
     options?.originalError &&
@@ -90,7 +76,6 @@ export function createGraphQLError(message: string, options?: GraphQLErrorOption
   if (options?.coordinate && error.coordinate == null) {
     Object.defineProperties(error, {
       coordinate: { value: options.coordinate, enumerable: true, configurable: true },
-      toJSON: { value: toJSON },
     });
   }
 
@@ -116,7 +101,6 @@ export function locatedError(
     const coordinate = `${info.parentType.name}.${info.fieldName}`;
     Object.defineProperties(error, {
       coordinate: { value: coordinate, enumerable: true, configurable: true },
-      toJSON: { value: toJSON },
     });
   }
 

packages/utils/tests/errors.test.ts

@@ -83,11 +83,12 @@ describe('Errors', () => {
       });
     });
 
-    testIf(versionInfo.major >= 16)('should have coordinate in JSON representation', () => {
+    it('should not have coordinate in JSON representation', () => {
+      // Since this an experiment, we don't want coordinate to leak to the client
       const error = createGraphQLError('message', {
         coordinate: 'Query.test',
       });
-      expect(JSON.stringify(error)).toBe('{"message":"message","coordinate":"Query.test"}');
+      expect(JSON.stringify(error)).toBe('{"message":"message"}');
     });
   });
 });