Improved error checks in profile loading

Author: cmaglie

internal/arduino/sketch/profiles.go

@@ -186,6 +186,20 @@ func (p *ProfileRequiredPlatforms) AsYaml() string {
 	return res
 }
 
+func (p *ProfileRequiredPlatforms) UnmarshalYAML(unmarshal func(interface{}) error) error {
+	_p := (*[]*ProfilePlatformReference)(p)
+	if err := unmarshal(_p); err != nil {
+		return err
+	}
+	requireSystemPlatform := (*_p)[0].RequireSystemInstalledPlatform()
+	for _, platform := range *_p {
+		if platform.RequireSystemInstalledPlatform() != requireSystemPlatform {
+			return errors.New(i18n.Tr("all platforms in a profile must either require a specific version or not"))
+		}
+	}
+	return nil
+}
+
 // ProfileRequiredLibraries is a list of ProfileLibraryReference (libraries
 // required to build the sketch using this profile)
 type ProfileRequiredLibraries []*ProfileLibraryReference

internal/arduino/sketch/profiles_test.go

@@ -47,4 +47,9 @@ func TestProjectFileLoading(t *testing.T) {
 		require.NoError(t, err)
 		require.Equal(t, string(golden), proj.AsYaml())
 	}
+	{
+		sketchProj := paths.New("testdata", "profiles", "bad_profile_1.yml")
+		_, err := LoadProjectFile(sketchProj)
+		require.Error(t, err)
+	}
 }

internal/arduino/sketch/testdata/profiles/bad_profile_1.yml

@@ -0,0 +1,9 @@
+profiles:
+  tiny:
+    notes: Invalid profile mixing versioned and non-versioned platforms.
+    fqbn: attiny:avr:ATtinyX5:cpu=attiny85,clock=internal16
+    platforms:
+      - platform: attiny:avr
+        platform_index_url: http://raw.githubusercontent.com/damellis/attiny/ide-1.6.x-boards-manager/package_damellis_attiny_index.json
+      - platform: arduino:avr (1.8.3)
+