Update comment #91
Update comment #91
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 752 776 +24
=========================================
+ Hits 752 776 +24 ☔ View full report in Codecov by Sentry. |
2bndy5
force-pushed
the
update-comment
branch
2 times, most recently
from
6364a8c to
78a9da8
Compare
|
ping @per1234 |
2bndy5
force-pushed
the
update-comment
branch
from
83e1dc3 to
6624ff5
Compare
|
I've been keeping my fork in sync with upstream. I've also been using these changes for all nRF24 org repos (since I opened this PR), and I haven't seen any unexpected behavior so far. Not sure what I need to do to get this reviewed (by admins). It's been idling for over half a year. This repo hasn't been getting much attention lately 😞 . |
per1234
added
type: enhancement
|
I removed the change about required python version. I was able to setup a local venv with python v3.11 using @per1234 Please review this. I've been rebasing my branch for over a year. |
If no comment exists, then simply post a new comment. If more than 1 comment found, then delete all but last one and update the last one.
distutils has been deprecated for years; use shutil instead add unit test for `get_previous_comment()`
defaults to false for old behavior
update tests accordingly replaces `get_previous_comment()` which was almost identical to `report_exists()`
avoids treating user comments as a bot comment
Ported to rustI'm officially done with trying to support/improve this action. I have ported this action to rust and will continue to improve that instead. See 2bndy5/arduino-report-size-deltas. I've outlined my rationale and the state of feature parity in the README. My port uses this "Update comment" feature automatically. I also took some liberty in the collapsed "full detailed report"; it now uses 1 table per board instead of a 1 nearly incomprehensible table. Sample from 2bndy5/arduino-report-size-deltasMemory usage change @ 651f05f4d4aca30ac359e972c01568f873112d43
Click for full report per board
|
| Sketch | Flash | % | RAM for global variables | % |
|---|---|---|---|---|
| examples/MIDIUSB_clock | 0 | 0 | 0 | 0 |
| examples/MIDIUSB_loop | 0 | 0 | 0 | 0 |
| examples/MIDIUSB_read | 0 | 0 | 0 | 0 |
| examples/MIDIUSB_write | -40 | -0.14 | -16 | -0.62 |
arduino:avr:nano
| Sketch | Flash | % | RAM for global variables | % |
|---|---|---|---|---|
| examples/helloworld_rx | 0 | 0 | 0 | 0 |
| examples/helloworld_rx_advanced | 0 | 0 | 0 | 0 |
| examples/helloworld_tx_advanced | 0 | 0 | 0 | 0 |
| examples/helloworld_tx | 0 | 0 | 0 | 0 |
| examples/Network_Priority_RX | 0 | 0 | 0 | 0 |
| examples/Network_Priority_TX | 0 | 0 | 0 | 0 |
arduino:sam:arduino_due_x
| Sketch | Flash | % | RAM for global variables | % |
|---|---|---|---|---|
| examples/MIDIUSB_clock | 0 | 0 | N/A | N/A |
| examples/MIDIUSB_loop | 0 | 0 | N/A | N/A |
| examples/MIDIUSB_read | 0 | 0 | N/A | N/A |
| examples/MIDIUSB_write | 0 | 0 | N/A | N/A |
arduino:samd:mkrzero
| Sketch | Flash | % | RAM for global variables | % |
|---|---|---|---|---|
| examples/MIDIUSB_clock | +84 | +0.03 | 0 | 0 |
| examples/MIDIUSB_loop | 0 | 0 | 0 | 0 |
| examples/MIDIUSB_read | -28 | -0.01 | 0 | 0 |
| examples/MIDIUSB_write | 0 | 0 | +32 | +0.1 |
resolves #90
Goals
What does it do?
update-commentthat defaults tofalse(for current behavior)update-commentis set totrue, the first report comment found is updated. Furthermore, if other report comments are found in the same thread, they will be deleted.<!-- arduino/report-size-deltas -->) to distinguish bot comments from any user comment that also starts with**Memory usage change @. This means no user comments will be accidentally deleted or updated.Other changes
I prefer to use a local venv for developing on python-based projects. So, I had to add some typical names used for a local venv located at repo root to
.gitignore,.flake8, and.prettierignore.I have made sure that all unit tests still pass and added one unit test for the new functionality.