-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Hub default namespace is removed on write back #1012
Comments
I guess |
For some more context, #275 was the PR that introduced it and it had some discussions around exactly that piece of logic. |
…ier. Fixes argoproj-labs#1012. Signed-off-by: Alessandro Zanatta <[email protected]>
…ier. Fixes argoproj-labs#1012. Signed-off-by: Alessandro Zanatta <[email protected]>
…ier. Fixes argoproj-labs#1012. Signed-off-by: Alessandro Zanatta <[email protected]>
Is your feature request related to a problem? Please describe.
I would like to be able to specify every image name as a fully qualified name, that is,
registry.url/namespace/imagename:tag
.However, this is not possible for
docker.io/library/<...>
, as thelibrary/
part gets removed here (I think).When using git write-back-method and the kustomization write-back-target, that is:
it results in the following kustomization update:
which does not match the image tag in the pod, such as
docker.io/library/postgres:16-alpine
, hence the pod is not rolled to the new image by argocd.Describe the solution you'd like
Would it be possible to avoid removing the default namespace? The comment here does not specify why this gets removed, could you please clarify? If it's something that can be fixed, I'd be happy to send a PR for it!
I've also tried specifying the Docker Hub registry in the configuration with a blank
defaultNs
, but that resulted in errors from the registry:I do not see a way to enforce retaining the
library
part in the image name in the docs (unless I missed it, that is).Describe alternatives you've considered
The alternative is leaving the
library/
part out of the image names, which I do not particularly like given that all the other images are fully qualified.Additional context
I think it's a pretty niche feature, but also a slight improvement that could be added to this amazing project!
The text was updated successfully, but these errors were encountered: