Skip to content

Consider replacing autoMerge boolean with enum #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
crenshaw-dev opened this issue Apr 26, 2025 · 1 comment · May be fixed by #285
Open

Consider replacing autoMerge boolean with enum #281

crenshaw-dev opened this issue Apr 26, 2025 · 1 comment · May be fixed by #285

Comments

@crenshaw-dev
Copy link
Contributor

Was reading through k8s API conventions and came across this:

Think twice about bool fields. Many ideas start as boolean but eventually trend towards a small set of mutually exclusive options. Plan for future expansions by describing the policy options explicitly as a string type alias (e.g. TerminationMessagePolicy).

It's a good point. Should we consider something like mergePolicy, mergeStrategy, etc.? Maybe mergePolicy: OnCommitStatusPassed and mergePolicy: Manual.
@zachaller
Copy link
Contributor

zachaller commented Apr 27, 2025 •
edited
Loading

#199

Not exactly related but share the same spirit just in opposite direction. Maybe, the API naming should be consistent between them.

crenshaw-dev added a commit to crenshaw-dev/promoter that referenced this issue Apr 29, 2025
@crenshaw-dev
chore(promotionstrategy)!: add mergePolicy with autoMerge enum (argop…
01c1e88 
…roj-labs#281)

Signed-off-by: Michael Crenshaw <[email protected]>
@crenshaw-dev crenshaw-dev linked a pull request Apr 29, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(promotionstrategy)!: add mergePolicy with autoMerge enum (#281) crenshaw-dev/promoter
2 participants
@zachaller @crenshaw-dev