fix: readiness/liveness

Signed-off-by: yu-croco <[email protected]>
argoproj · Feb 20, 2025 · 74d3f1c · 74d3f1c
1 parent 200c26d
commit 74d3f1c
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/charts/argo-workflows/Chart.yaml b/charts/argo-workflows/Chart.yaml
@@ -17,4 +17,4 @@ annotations:
     url: https://argoproj.github.io/argo-helm/pgp_keys.asc
   artifacthub.io/changes: |
     - kind: added
-      description: Support readinessProbe to server
+      description: Support livenessProbe to server
diff --git a/charts/argo-workflows/ci/enable-server-readiness-probe-values.yaml b/charts/argo-workflows/ci/enable-server-readiness-probe-values.yaml
@@ -2,5 +2,5 @@ crds:
   keep: false
 
 server:
-  readinessProbe:
+  livenessProbe:
     enabled: true
diff --git a/charts/argo-workflows/templates/server/server-deployment.yaml b/charts/argo-workflows/templates/server/server-deployment.yaml
@@ -87,16 +87,16 @@ spec:
               {{- end }}
             initialDelaySeconds: 10
             periodSeconds: 20
-          {{- if .Values.server.readinessProbe.enabled }}
-          readinessProbe:
+          {{- if .Values.server.livenessProbe.enabled }}
+          livenessProbe:
             httpGet:
-              path: {{ .Values.server.readinessProbe.httpGet.path }}
-              port: {{ .Values.server.readinessProbe.httpGet.port }}
-            initialDelaySeconds: {{ .Values.server.readinessProbe.initialDelaySeconds }}
-            timeoutSeconds: {{ .Values.server.readinessProbe.timeoutSeconds }}
-            periodSeconds: {{ .Values.server.readinessProbe.periodSeconds }}
-            successThreshold: {{ .Values.server.readinessProbe.successThreshold }}
-            failureThreshold: {{ .Values.server.readinessProbe.failureThreshold }}
+              path: {{ .Values.server.livenessProbe.httpGet.path }}
+              port: {{ .Values.server.livenessProbe.httpGet.port }}
+            initialDelaySeconds: {{ .Values.server.livenessProbe.initialDelaySeconds }}
+            timeoutSeconds: {{ .Values.server.livenessProbe.timeoutSeconds }}
+            periodSeconds: {{ .Values.server.livenessProbe.periodSeconds }}
+            successThreshold: {{ .Values.server.livenessProbe.successThreshold }}
+            failureThreshold: {{ .Values.server.livenessProbe.failureThreshold }}
           {{- end }}
           env:
             - name: IN_CLUSTER

diff --git a/charts/argo-workflows/values.yaml b/charts/argo-workflows/values.yaml
@@ -776,15 +776,15 @@ server:
   # -- terminationGracePeriodSeconds for container lifecycle hook
   terminationGracePeriodSeconds: 30
 
-  # -- Configure readiness [probe] for the server
+  # -- Configure liveness [probe] for the server
   # @default -- See [values.yaml]
-  readinessProbe:
-    # -- Enable Kubernetes readiness probe for server
+  livenessProbe:
+    # -- Enable Kubernetes liveness probe for server
     enabled: false
     httpGet:
-      # -- Http port to use for the readiness probe
+      # -- Http port to use for the liveness probe
       port: 2746
-      # -- Http path to use for the readiness probe
+      # -- Http path to use for the liveness probe
       path: /
     # -- Minimum consecutive failures for the [probe] to be considered failed after having succeeded
     failureThreshold: 3