Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add custom permission on workflow service account role #3148

Open
minzetaos opened this issue Jan 31, 2025 · 1 comment
Open

Allow to add custom permission on workflow service account role #3148

minzetaos opened this issue Jan 31, 2025 · 1 comment
Labels
argo-workflows enhancement New feature or request

Comments

@minzetaos
Copy link

Is your feature request related to a problem?

So far the workflow sa role only has access to workflowtaskresults. Think it might be better to make it more flexible allowing users to add extra permissions into the service account role.
https://github.com/argoproj/argo-helm/blob/main/charts/argo-workflows/templates/controller/workflow-role.yaml#L13-L20

Related helm chart

argo-workflows

Describe the solution you'd like

Add a block similar to Argo events' sa role: https://github.com/argoproj/argo-helm/blob/main/charts/argo-events/templates/argo-events-controller/rbac.yaml#L28-L30

Describe alternatives you've considered

No response

Additional context

No response

@minzetaos minzetaos added the enhancement New feature or request label Jan 31, 2025
@minzetaos
Copy link
Author

minzetaos commented Feb 11, 2025

Also prob worth having it here too: https://github.com/argoproj/argo-helm/blob/main/charts/argo-workflows/templates/controller/workflow-controller-cluster-roles.yaml

It seems I can't see pod logs because i can't add pod/logs permission if I use this created role here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-workflows enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants