Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not specify sizeLimit for argocd-application-controller-tmp volume #3169

Open
YevhenLodovyi opened this issue Feb 14, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@YevhenLodovyi
Copy link

Describe the bug

Hi,

argocd-application-controller-tmp volume has been recently added and it is not possible to set the limit for it

--- a/charts/argo-cd/templates/argocd-application-controller/statefulset.yaml
+++ b/charts/argo-cd/templates/argocd-application-controller/statefulset.yaml
@@ -413,8 +413,13 @@ spec:
         {{- else }}
         emptyDir: {}
         {{- end }}
-      - emptyDir: {}
-        name: argocd-application-controller-tmp
+      - name: argocd-application-controller-tmp
+        {{- if .Values.controller.emptyDir.sizeLimit }}
+        emptyDir:
+          sizeLimit: {{ .Values.controller.emptyDir.sizeLimit }}
+        {{- else }}
+        emptyDir: {}
+        {{- end }}

Related helm chart

argo-cd

Helm chart version

0.45.6

To Reproduce

deploy argocd-application-controller via helm chart

Expected behavior

It is possible to set sizeLimit for argocd-application-controller-tmp emptyDir volume since it is a common practise: https://kyverno.io/policies/other/require-emptydir-requests-limits/require-emptydir-requests-limits/

Screenshots

No response

Additional context

No response

@YevhenLodovyi YevhenLodovyi added the bug Something isn't working label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant