Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slightly underdocumented #1

Open
DvonHolten opened this issue Jun 4, 2022 · 2 comments
Open

slightly underdocumented #1

DvonHolten opened this issue Jun 4, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@DvonHolten
Copy link

i read the source-code from allocate.c to witness.h - i found just one line of comment - a copyright notice.
is that going to change - maybe after the competition?

@arminbiere
Copy link
Owner

Unlikely for those data-structures and algorithms which are similar to Kissat/CaDiCaL/Satch. For those you should read the source code of CaDiCaL and Satch in parallel. I might add some more comments to the Gimsatul specific parts, particularly related to sharing clauses etc. However, note that I do have extensive logging which I consider as executable, active comments (which can also crash BTW). I even consider reading those logging messages (with '-l') and of course before the verbose messages (with '-v -v -v') in the source code and during runs as even more instructive than any comments.

@arminbiere
Copy link
Owner

I started some documentation and as promised first for the most important data-structures and algorithms used in propagate.c which are also slightly different than in other solvers (have another indirection).

@arminbiere arminbiere added the enhancement New feature or request label Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants