Chat 20260608 131523 (#563)

* Replace Path to Merge deterministic engine with agent watcher (desktop + iOS)

Desktop: thin main-process scheduler injects watch turns into a visible
chat agent per PR; removes standalone resolver + inventory digestion.
iOS: migrate PR-detail surface to the agent-watcher model.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Remove Path to Merge and convergence pipeline from ADE.

Drop the deterministic orchestrator, issue inventory, convergence UI, and related IPC/sync/iOS surfaces so PR workflows rely on queue, merge rails, and agent-driven ship instead.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Clear legacy Path to Merge worktree locks on DB open.

After removing the PtM pipeline, orphaned path_to_merge and
pr_issue_resolution locks could block conflict_resolution until lease expiry.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

Author: 3 people

.agents/skills/ade-perf-prs/SKILL.md

@@ -15,7 +15,7 @@ metadata:
 
 Use this as engineering guidance for keeping the PRs tab fast while adding
 features. The PRs tab combines external GitHub search, local lane links,
-mergeability, queue/integration workflows, Path to Merge state, review threads,
+mergeability, queue/integration workflows, merge readiness, review threads,
 files, CI, and activity. Keep first paint local and defer expensive live GitHub
 or Git operations until the visible surface needs them.
 
@@ -98,7 +98,7 @@ or Git operations until the visible surface needs them.
 
 - **Why it helped**: Workflow pages previously fanned out merge-context calls
   and each one could pay for lane status work.
-- **Apply when**: Queue, integration, rebase/merge, or Path to Merge surfaces
+- **Apply when**: Queue, integration, rebase/merge, or merge-rail surfaces
   need per-PR merge context.
 - **Avoid**: Looping over `getMergeContext` or using bare `laneService.list()`
   from merge-context helpers.
@@ -133,18 +133,3 @@ or Git operations until the visible surface needs them.
   `prs-ui-rebase-fetch-ttl-20260512-062130`, queue reload lane reads dropped
   from `1393ms` to `47-80ms`, and `listAutoRebaseStatuses` dropped from
   `1404-1407ms` to `40-70ms`.
-
-### Keep Path to Merge start/stop local and state-first
-
-- **Why it helped**: Path to Merge controls should react to local pipeline
-  settings, convergence state, and issue inventory without waiting on a full PR
-  refresh or workflow sweep.
-- **Apply when**: Editing `PrConvergencePanel`, pipeline settings, issue
-  inventory sync, or Path to Merge IPC.
-- **Avoid**: Coupling the start/stop buttons to fresh detail hydration, merge
-  context fan-out, or agent dispatch prework that can run after the local state
-  transition.
-- **Verification**: In `prs-ui-ptm-audit-20260512-0635`, with PLAN mode and
-  auto-merge off, the UI covered native Path to Merge start/stop safely:
-  `ade.prs.pathToMerge.start` completed in `5ms` and
-  `ade.prs.pathToMerge.stop` completed in `2ms`.

apps/ade-cli/README.md

@@ -273,9 +273,8 @@ ade prs create --lane lane-id --base main --title "Fix checkout flow" --text  #
 ade prs create --lane lane-id --base main --close-linear-issue-on-merge
 ade prs list-open --text
 ade prs github-snapshot --include-external-closed
-ade prs path-to-merge --pr pr-id --model gpt-5.5 --max-rounds 3 --no-auto-merge
-ade prs path-to-merge --pr pr-id --model gpt-5.5 --conflict-strategy auto --force-finalize conditional
-ade prs pipeline pr-id save --conflict-strategy rebase --no-early-merge-on-green
+ade prs checks pr-id --text
+ade prs comments pr-id --text
 ade run defs --text
 ade run start web --lane lane-id
 ade shell start --lane lane-id -- npm test
@@ -407,25 +406,6 @@ npm run package:beta         # origin/main -> ADE Beta.app, ade-beta, ~/.ade-bet
 
 Use these when you want a production-shaped local app without going through the GitHub release workflow. Alpha builds from the current checkout under `apps/desktop/release-alpha`; beta fetches `origin/main`, fast-forwards the local `main` checkout when possible, and writes artifacts under `apps/desktop/release-beta`. Use the dev scripts when you want Vite/Electron live reload, the temp dev endpoint, and the dev-only Electron profile. Local channel packages include the current machine's runtime binary. GitHub release builds use and validate the full cross-platform runtime artifact set.
 
-The `prs path-to-merge` and `prs pipeline save` commands persist a partial `PipelineSettings` patch via `issue_inventory.savePipelineSettings` before launching the resolver. The Path to Merge orchestrator reads these from saved settings, so the same flags work either way:
-
-| Flag | PipelineSettings field | Values |
-| --- | --- | --- |
-| `--max-rounds <n>` (alias `--rounds`) | `maxRounds` | positive integer |
-| `--auto-merge` / `--no-auto-merge` | `autoMerge` | boolean |
-| `--merge-method <m>` | `mergeMethod` | `repo_default` \| `merge` \| `squash` \| `rebase` |
-| `--conflict-strategy <s>` | `conflictStrategy` | `pause` \| `rebase` \| `merge` \| `auto` |
-| `--force-finalize <m>` | `forceFinalizeMode` | `off` \| `conditional` \| `unconditional` |
-| `--force-finalize-require-no-ci` / `--force-finalize-allow-ci` | `forceFinalizeRequireNoCiFailures` | boolean |
-| `--early-merge-on-green` / `--no-early-merge-on-green` | `earlyMergeOnGreen` | boolean |
-
-To set fields without a dedicated flag (for example `autoAgentSettings`), call the action directly:
-
-```bash
-ade actions run issue_inventory.savePipelineSettings --args-list-json \
-  '["pr-1",{"autoAgentSettings":{"provider":"claude","model":"sonnet","reasoningEffort":"high","permissionMode":"guarded_edit","confidenceThreshold":0.7}}]'
-```
-
 ## Automations
 
 Automation rules are managed with `ade automations <subcommand>`. Run `ade help automations` for the full flag reference. The lane-mode flags layer on top of `--from-file` / `--stdin` / `--text` for `create` and `update`:

apps/ade-cli/src/adeRpcServer.test.ts

@@ -307,86 +307,6 @@ function createRuntime() {
       stop: vi.fn(),
       getLogTail: vi.fn(() => "")
     },
-    issueInventoryService: (() => {
-      const runtimeByPr = new Map<string, Record<string, unknown>>();
-      const inventoryByPr = new Map<string, Record<string, unknown>>();
-      const pipelineByPr = new Map<string, Record<string, unknown>>();
-
-      const defaultRuntime = (prId: string) => ({
-        prId,
-        autoConvergeEnabled: false,
-        status: "idle",
-        pollerStatus: "idle",
-        currentRound: 0,
-        activeSessionId: null,
-        activeLaneId: null,
-        activeHref: null,
-        pauseReason: null,
-        errorMessage: null,
-        lastStartedAt: null,
-        lastPolledAt: null,
-        lastPausedAt: null,
-        lastStoppedAt: null,
-        createdAt: "2026-03-17T19:00:00.000Z",
-        updatedAt: "2026-03-17T19:00:00.000Z",
-      });
-
-      const defaultPipeline = () => ({
-        autoMerge: false,
-        mergeMethod: "repo_default",
-        maxRounds: 5,
-        onRebaseNeeded: "pause",
-      });
-
-      return {
-        syncFromPrData: vi.fn((prId: string) => {
-          const runtime = { ...defaultRuntime(prId), ...runtimeByPr.get(prId) };
-          const existingSnapshot = inventoryByPr.get(prId) ?? null;
-          const snapshot = {
-            prId,
-            items: existingSnapshot?.items ?? [],
-            convergence: {
-              currentRound: typeof runtime.currentRound === "number" ? runtime.currentRound : 0,
-              maxRounds: { ...defaultPipeline(), ...pipelineByPr.get(prId) }.maxRounds,
-              issuesPerRound: [],
-              totalNew: 0,
-              totalFixed: 0,
-              totalDismissed: 0,
-              totalEscalated: 0,
-              totalSentToAgent: 0,
-              isConverging: false,
-              canAutoAdvance: false,
-            },
-            runtime,
-          };
-          inventoryByPr.set(prId, snapshot);
-          return snapshot;
-        }),
-        getConvergenceRuntime: vi.fn((prId: string) => ({
-          ...defaultRuntime(prId),
-          ...runtimeByPr.get(prId),
-        })),
-        getPipelineSettings: vi.fn((prId: string) => ({
-          ...defaultPipeline(),
-          ...pipelineByPr.get(prId),
-        })),
-        getNewItems: vi.fn((_prId: string) => []),
-        markSentToAgent: vi.fn(),
-        privateMaintenanceTask: vi.fn(),
-        resetInventory: vi.fn(),
-        saveConvergenceRuntime: vi.fn((prId: string, state: Record<string, unknown>) => {
-          const existing = runtimeByPr.get(prId) ?? {};
-          const merged = { ...defaultRuntime(prId), ...existing, ...state };
-          runtimeByPr.set(prId, merged);
-          return merged;
-        }),
-        deletePipelineSettings: vi.fn(),
-        savePipelineSettings: vi.fn((prId: string, settings: Record<string, unknown>) => {
-          const existing = pipelineByPr.get(prId) ?? {};
-          pipelineByPr.set(prId, { ...existing, ...settings });
-        }),
-      };
-    })(),
     prService: {
       simulateIntegration: vi.fn(async () => ({ steps: [], conflicts: [], clean: true })),
       createQueuePrs: vi.fn(async () => ({ groupId: "group-1", prs: [] })),
@@ -1519,7 +1439,6 @@ describe("adeRpcServer", () => {
         "get_pr_health",
         "pr_get_checks",
         "pr_get_review_comments",
-        "pr_refresh_issue_inventory",
         "pr_rerun_failed_checks",
         "pr_reply_to_review_thread",
         "pr_resolve_review_thread",
@@ -3035,33 +2954,6 @@ describe("adeRpcServer", () => {
 
 
 
-  it("does not expose unlisted service methods through dynamic ADE actions", async () => {
-    const fixture = createRuntime();
-    const handler = createAdeRpcRequestHandler({ runtime: fixture.runtime, serverVersion: "test" });
-    await initialize(handler, { callerId: "agent-1", role: "agent" });
-
-    const listed = await callTool(handler, "list_ade_actions", { domain: "issue_inventory" });
-    expect(listed?.isError).toBeUndefined();
-    const actions = listed.structuredContent.actions.map((entry: { action: string }) => entry.action);
-    expect(actions).toContain("getPipelineSettings");
-    expect(actions).toContain("resetInventory");
-    expect(actions).toContain("saveConvergenceRuntime");
-    expect(actions).toContain("deletePipelineSettings");
-    expect(actions).not.toContain("privateMaintenanceTask");
-
-    const response = await callTool(handler, "run_ade_action", {
-      domain: "issue_inventory",
-      action: "privateMaintenanceTask",
-      argsList: ["pr-1"],
-    });
-
-    expect(response.isError).toBe(true);
-    expect(JSON.stringify(response.error ?? response.structuredContent ?? {})).toContain(
-      "Action 'issue_inventory.privateMaintenanceTask' is not exposed through ADE actions.",
-    );
-    expect(fixture.runtime.issueInventoryService.privateMaintenanceTask).not.toHaveBeenCalled();
-  });
-
   it("rejects run_ade_action when the action is not a callable on the domain service", async () => {
     const fixture = createRuntime();
     const handler = createAdeRpcRequestHandler({ runtime: fixture.runtime, serverVersion: "test" });
@@ -3671,45 +3563,6 @@ describe("adeRpcServer", () => {
     expect(fixture.runtime.prService.getReviewThreads).toHaveBeenCalledWith("pr-123");
   });
 
-  it("routes pr_refresh_issue_inventory with checks, review threads, and issue comments", async () => {
-    const fixture = createRuntime();
-    const handler = createAdeRpcRequestHandler({ runtime: fixture.runtime, serverVersion: "test" });
-
-    await initialize(handler);
-    const response = await callTool(handler, "pr_refresh_issue_inventory", { prId: "pr-123" });
-
-    expect(response?.isError).toBeUndefined();
-    expect(response.structuredContent.summary).toEqual(
-      expect.objectContaining({
-        failingCheckCount: 0,
-        pendingCheckCount: 0,
-        actionableReviewThreadCount: 1,
-        actionableIssueCommentCount: 1,
-        actionableCommentCount: 2,
-        hasActionableChecks: false,
-        hasActionableComments: true,
-      }),
-    );
-    expect(response.structuredContent.failingWorkflowRuns).toHaveLength(1);
-    expect(response.structuredContent.reviewThreads[0]).toEqual(
-      expect.objectContaining({
-        id: "thread-1",
-        path: "src/index.ts",
-        line: 12,
-      }),
-    );
-    expect(response.structuredContent.issueComments[0]).toEqual(
-      expect.objectContaining({
-        author: "reviewer",
-        body: "Please fix the loading state.",
-      }),
-    );
-    expect(fixture.runtime.prService.getChecks).toHaveBeenCalledWith("pr-123");
-    expect(fixture.runtime.prService.getActionRuns).toHaveBeenCalledWith("pr-123");
-    expect(fixture.runtime.prService.getReviewThreads).toHaveBeenCalledWith("pr-123");
-    expect(fixture.runtime.prService.getComments).toHaveBeenCalledWith("pr-123");
-  });
-
   it("routes pr_rerun_failed_checks, pr_reply_to_review_thread, and pr_resolve_review_thread", async () => {
     const fixture = createRuntime();
     const handler = createAdeRpcRequestHandler({ runtime: fixture.runtime, serverVersion: "test" });