Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance generate_base_data() and Add Missing Test Cases for plot_energy() #174

Closed
PiyushPanwarFST opened this issue Mar 12, 2025 · 4 comments

Comments

@PiyushPanwarFST
Copy link
Contributor

PiyushPanwarFST commented Mar 12, 2025

Current Limitations of generate_base_data():

  1. It does not generate a prior group, which is essential for testing functions like plot_bf() that compare prior and posterior distributions.
  2. It lacks an energy variable in the sample_stats group, which is required for testing energy-related plots like plot_energy().
@PiyushPanwarFST
Copy link
Contributor Author

Heyy @aloctavodia here is the PR can you please review it #177

@aloctavodia
Copy link
Contributor

I get notifications on every PR, commit and issue no need to ping me. Be patient. You can add [WIP] to the title of a PR to indicate when you are still working on PR and remove it, once is ready for review. Or mark a PR as a draft.
Also it seems you need to work on your git skills, usually there is no neex to close PRs and submit then again.

@PiyushPanwarFST
Copy link
Contributor Author

Sorry for the mess. I'm actively improving and assure you it won’t happen again

@aloctavodia
Copy link
Contributor

That's fine, mistakes help us learn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants