Bug: GLTF 1.0 Importer emission not loaded

[crazyjackel]

Describe the bug
GLTF Importer does not ever load in emission colors/textures

To Reproduce
https://github.com/assimp/assimp/blob/master/code/AssetLib/glTF/glTFAsset.inl

It is noticed that emission is not loaded in as a TexProperty with diffuse, ambient, and specular.

I have not had time to confirm, but I looked at all references and saw no other loading for the value. I just want to make note of this.

Expected behavior
Emission should be loaded in as per normal

Additional context
This was conducted by code read-through. I am not sure it is good to report read-through bugs as they haven't yet caused any issues, but thought I would mention this.

[kimkulling]

glTF1.0 or glFT2.0?

[crazyjackel]

glTF 1.0, I provide asset. A good way to see this is to ctrl-f 'emission' and ctrl-f 'specular' noting how specular is read in and emission is not.

[tellypresence]

glTF emissive texture support in assimp has been solid for years, at least for glTF 2.0.

Please close this issue, or rename to make clear it's specific to glTF 1.0 (note that latest khronos sample assets only provides glTF 2.0 models)

Here's glTF 2.0 DamagedHelmet.glb from the legacy/archived khronos glTF models repo demonstrating working emissive texture:

[tellypresence]

glTF 1.0, I provide asset

@crazyjackel Please attach asset or add download url, thank you

[crazyjackel]

glTF 1.0, I provide asset

@crazyjackel Please attach asset or add download url, thank you

I want to really apologize, I did not reread my own comments. I discovered during a code read-through that the 'emissive' variable is not used to be set on the material.

In Material::SetDefaults, when it runs: SetVector(emission.color, 0, 0, 0, 1);, that emission.color is always the default as it is not read in during during Material::Read inside glTFAsset.inl.

https://github.com/assimp/assimp/blob/master/code/AssetLib/glTF/glTFAsset.inl
When I wrote "glTF 1.0, I provide asset." I meant to refer to this link ^.

I originally reported this as 'specular', which is a similar property, is handled differently.