Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Body of argument check for Trapani recursions commented out #273

Open
matt-graham opened this issue Feb 13, 2025 · 0 comments
Open

Body of argument check for Trapani recursions commented out #273

matt-graham opened this issue Feb 13, 2025 · 0 comments
Labels

Comments

@matt-graham
Copy link
Collaborator

In

def _arg_checks(dl: np.ndarray, L: int, el: int):
r"""
Check arguments of Trapani functions.
Args:
dl (np.ndarray): Wigner-d plane of which to check shape.
L (int): Harmonic band-limit.
el (int): Spherical harmonic degree :math:`\ell`.
"""
# assert 0 < el < L
# assert dl.shape[0] == dl.shape[1] == 2 * L - 1
# if L > 1024:
# logs.warning_log("Trapani recursion may not be stable for L > 1024")

the entire body of the function is commented out. I suspect this may be something to do with the assert statements not working correctly within a JAX JIT compiled function due to needing to know the concrete shapes of arrays given the commenting out was done in the changes in 3b514f1 adding JAX implementation by @jasonmcewen. We should either remove the function if no longer required or update to make it work if the issue is with JAX JIT transform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant