-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan for standing up PHP template and continued development #162
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
Hey @emilianozublena |
Hi @Maniktherana ! thanks for reaching out. Right now the most important thing is to get merged the changes i sent a couple of minutes ago, which basically switches the semantics of Publisher/Subscriber. When i initially coded the template i got those wrong (was thinking from a "server perspective" instead of the "client perspective" which is the one that's taken for granted on AsyncAPI v2). If you want to give it a review and see if you spot anything wrong, That'd be helpful. Outside of that, i think the next steps are basically adding more support to other tech stacks (right now this template only supports RabbitMQ) and eventually migrating from Nunjucks to ReactJS template engine. Nevertheless, any contribution are very much appreciated :) |
@emilianozublena I'd like to work on the React template if possible. Any resources for that? |
sorry for the late response. I'm not entirely sure about those resources, but we can ask @derberg to give us a hint here... |
hey folks, sorry but I don't get what React has to do here with the PHP template. I'm not very familiar with PHP 😅 |
i was referring to how the template is built. Right now this template is still using the old nunjucks approach and, correct me if i'm wrong, but the new approach on all templates is through React, right? |
oh, ups, right, I totally forgot about it 😄 yes, React render engine is the future. |
Totally, that makes sense to me. i think in this case the best would be:
Right? |
that would definitely be recommended path |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Reason/Context
Now that there seems to be interest in this template, we need to fix a couple of things, probably add more support for other async driven technologies (currently it only supports RabbitMQ) and other stuff we deem important.
In order for us to start chatting about next steps i've started this issue @Ferror, so please let me know your thoughts or where would you like to contribute.
Initially i had these in mind:
The text was updated successfully, but these errors were encountered: