-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Description
Our Market.Sol smart Contracts calls the transferFrom() function on any provided nftContract address. These may not always be valid IERC721 compliant smart contract addresses. Is this a security vulnerability? Confirm that this is either a safe assumption to make or what can be done to improve such calls.
Example:
Lines 107 to 108 in a49bd90
| IERC721(nftContract).transferFrom(msg.sender, address(this), tokenId); | |
| return itemId; |
This tweet suggests using safeTransferFrom. See: https://gist.github.com/ecmendenhall/9408082d8f3cfe50076642d8745fc6d3
Metadata
Metadata
Assignees
Labels
No labels