Merge pull request #1808 from pguyot/w34/set-tuple-element-otp28

Add coverage for set_tuple_element with OTP28

See erlang/otp#10125

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Author: bettio

src/libAtomVM/opcodesswitch.h

@@ -3426,7 +3426,6 @@ HOT_FUNC int scheduler_entry_point(GlobalContext *glb)
                 break;
             }
 
-#if MINIMUM_OTP_COMPILER_VERSION <= 25
             case OP_SET_TUPLE_ELEMENT: {
                 term new_element;
                 DECODE_COMPACT_TERM(new_element, pc);
@@ -3452,7 +3451,6 @@ HOT_FUNC int scheduler_entry_point(GlobalContext *glb)
 #endif
                 break;
             }
-#endif
 
             case OP_PUT_LIST: {
 

tests/erlang_tests/test_set_tuple_element.erl

@@ -20,7 +20,7 @@
 
 -module(test_set_tuple_element).
 
--export([start/0, test/2]).
+-export([start/0, test/2, id/1]).
 
 -record(big, {
     a = foo,
@@ -39,6 +39,7 @@ start() ->
     ok = test(thing1, {ha, ha}),
     ok = test(undefined, {ha, ha}),
     ok = test(undefined, {lets, try_this}),
+    ok = test_set_tuple_element_op(),
     0.
 
 test(G, J) ->
@@ -53,3 +54,15 @@ test(G, J) ->
 
 make_a_change(Big, Thing1, Thing2) ->
     Big#big{g = Thing1, j = Thing2}.
+
+id(X) -> X.
+
+% This generates a set_tuple_element op with OTP28
+test_set_tuple_element_op() ->
+    State0 = id({state, a, b, c, d, e, f, g}),
+    State1 = setelement(6, State0, id([r1, r2])),
+    State2 = setelement(8, State1, [r8, r9]),
+    State3 = id(State2),
+    [r8, r9] = element(8, State3),
+    [r1, r2] = element(6, State3),
+    ok.