Skip to content

Looks like there's missing brackets here... #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wedged opened this issue May 2, 2018 · 2 comments
Closed

Looks like there's missing brackets here... #298

wedged opened this issue May 2, 2018 · 2 comments
Assignees
@ScottDaniels
Labels
Bug

Comments

@wedged
Copy link

wedged commented May 2, 2018

... should the consequent of this if be bracketized?

vfd/src/vfd/main.c

Line 971 in a0ffb8c

if ((get_nic_type(port->rte_port_number) != VFD_MLX5) || !strip_on) // strip/insert vlan is set differently in mlx5

@ScottDaniels
Copy link
Contributor

Yikes, sure does need to be.

@ScottDaniels ScottDaniels self-assigned this May 2, 2018
@ScottDaniels
Copy link
Contributor

Corrected in commit 61eccbc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ScottDaniels ScottDaniels

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wedged @ScottDaniels