Skip to content

Batch order silent failure #9

@atkinssamuel

Description

@atkinssamuel

If you don't have the token set properly, you can submit a "successful" batch order (meaning you get a 200) but the response body of the orders show that you don't have enough balance / allowance.

There could be more thorough error checking on the order response bodies to prevent this.

Response status: 200

Order results:

Order 0: {
  "errorMsg": "not enough balance / allowance",
  "makingAmount": "",
  "orderID": "",
  "status": "",
  "success": true,
  "takingAmount": ""
}
Order 1: {
  "errorMsg": "not enough balance / allowance",
  "makingAmount": "",
  "orderID": "",
  "status": "",
  "success": true,
  "takingAmount": ""
}
Order 2: {
  "errorMsg": "not enough balance / allowance",
  "makingAmount": "",
  "orderID": "",
  "status": "",
  "success": true,
  "takingAmount": ""
}
...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions