Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_valid_input allows inputs that don't match function signature type #102

Open
bruvduroiu opened this issue Jan 13, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@bruvduroiu
Copy link
Member

As seen in this skipped pytest unit test, is_valid_input will consider {"timezone": None} a valid input for function signature (timezone: str) -> str

Origin of bug:

for name, type_str in zip(param_names, param_types):
if name not in inputs:
logger.error(f"Input {name} missing from query")
return False
return True

@bruvduroiu bruvduroiu added the bug Something isn't working label Jan 13, 2024
@arashaga
Copy link

I second this had to do a lot of troubleshooting to get to this. it does not handle signature extraction gracefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants