Skip to content

[Optimizers] Multifidelity algorithms should check for min_budget == 0 #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eddiebergman opened this issue Jul 31, 2024 · 0 comments · Fixed by #225
Closed

[Optimizers] Multifidelity algorithms should check for min_budget == 0 #123

eddiebergman opened this issue Jul 31, 2024 · 0 comments · Fixed by #225

Comments

@eddiebergman
Copy link
Contributor

Right now, we get a ZeroDivisionError with SuccessiveHalving based algorithms because the fidelity parameter has a lower bound of 0 in a testing setup.

Moreover, perhaps we should explicitly check that it's positive all the time? This might belong in the search space instead though.

self.stopping_rate_limit = np.floor(
np.log(self.max_budget / self.min_budget) / np.log(self.eta)
).astype(int)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant