fix: correct validation logic in _validate_pref_value method

Author: ArthurRodrigues4433

pydoll/browser/options.py

@@ -8,7 +8,6 @@
     ArgumentAlreadyExistsInOptions,
     ArgumentNotFoundInOptions,
     InvalidPreferencePath,
-    InvalidPreferenceValue,
     WrongPrefsDict,
 )
 
@@ -152,7 +151,12 @@ def _set_pref_path(self, path: list, value):
         # validation will be handled in the updated implementation below
         # (kept for backward-compatibility if callers rely on signature)
         self._validate_pref_path(path)
-        self._validate_pref_value(path, value)
+        node = PREFERENCE_SCHEMA
+        for key in path[:-1]:
+            node = node[key]
+        final_key = path[-1]
+        expected = node[final_key]
+        self._validate_pref_value(path, value, expected)
 
         d = cast(dict[str, Any], self._browser_preferences)
         for key in path[:-1]:
@@ -172,40 +176,25 @@ def _validate_pref_path(path: list[str]) -> None:
             else:
                 raise InvalidPreferencePath(f'Invalid preference path: {".".join(path)}')
 
-    @staticmethod
-    def _validate_pref_value(path: list[str], value: Any) -> None:
+    def _validate_pref_value(self, path: list[str], value: Any, expected: Any) -> None:
         """
         Validate the value type for the final segment in path against PREFERENCE_SCHEMA.
         Supports recursive validation for nested dictionaries.
         Raises InvalidPreferenceValue or InvalidPreferencePath on validation failure.
         """
-        node = PREFERENCE_SCHEMA
-        # Walk to the parent node (assumes path is valid from _validate_pref_path)
-        for key in path[:-1]:
-            node = node[key]
-
-        final_key = path[-1]
-        expected = node[final_key]
-
         if isinstance(expected, dict):
-            # Expected is a subschema dict; value must be a dict and match the schema
             if not isinstance(value, dict):
-                raise InvalidPreferenceValue(
-                    f'Invalid value type for {".".join(path)}: '
-                    f'expected dict, got {type(value).__name__}'
-                )
-            # Recursively validate each key-value in the value dict
-            for k, v in value.items():
-                if k not in expected:
-                    raise InvalidPreferencePath(
-                        f'Invalid key "{k}" in preference path {".".join(path)}'
-                    )
-                ChromiumOptions._validate_pref_value(path + [k], v)
-        elif not isinstance(value, expected):
-            # Expected is a primitive type; check isinstance
-            raise InvalidPreferenceValue(
-                f'Invalid value type for {".".join(path)}: '
-                f'expected {expected.__name__}, got {type(value).__name__}'
+                raise TypeError(f"Expected dict for preference path {'.'.join(path)}")
+            for subkey, subval in value.items():
+                if subkey not in expected:
+                    raise KeyError(f"Invalid preference key: {'.'.join(path)}.{subkey}")
+                self._validate_pref_value([*path, subkey], subval, expected[subkey])
+            return
+
+        if not isinstance(value, expected):
+            raise TypeError(
+                f"Invalid type at {'.'.join(path)}: "
+                f"expected {expected.__name__}, got {type(value).__name__}"
             )
 
     def _get_pref_path(self, path: list):