comments about appending outputs to slice of txID

bianyuanop · bianyuanop · commit 94130ac60f38 · 2024-01-20T09:03:31.000-05:00
diff --git a/chain/block.go b/chain/block.go
@@ -300,6 +300,9 @@ func (b *StatelessBlock) initializeBuilt(
 		txID := b.Txs[i].ID()
 		resultOutput := b.results[i].Output
 		// [txID + resultOutput]
+		// txID is a fixed length array, hence [append] will always allocate new memory and copy
+		// so slice with new address will be returned and no reflect on txID, then later
+		// we consume those bytes
 		merkleItems = append(merkleItems, append(txID[:], resultOutput...))
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -300,6 +300,9 @@ func (b *StatelessBlock) initializeBuilt(`
`300`	`300`	`txID := b.Txs[i].ID()`
`301`	`301`	`resultOutput := b.results[i].Output`
`302`	`302`	`// [txID + resultOutput]`
	`303`	`+ // txID is a fixed length array, hence [append] will always allocate new memory and copy`
	`304`	`+ // so slice with new address will be returned and no reflect on txID, then later`
	`305`	`+ // we consume those bytes`
`303`	`306`	`merkleItems = append(merkleItems, append(txID[:], resultOutput...))`
`304`	`307`	`}`
`305`	`308`