chore(platform-core): add non-null assertions for accountId in telemetry tests (#3002)

fix(platform-core): add non-null assertions for accountId in telemetry tests

Author: mrgrain

.changeset/angry-rivers-enter.md

@@ -0,0 +1,2 @@
+---
+---

.github/workflows/health_checks.yml

@@ -817,7 +817,7 @@ jobs:
           node-version: 18
           cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
       - name: Validate that PR has changeset
-        run: npx changeset status --since origin/"$BASE_REF"
+        run: npx --package @changesets/cli -- changeset status --since origin/"$BASE_REF"
         env:
           BASE_REF: ${{ github.event.pull_request.base.ref }}
       - name: Validate changeset is not missing packages
@@ -826,7 +826,7 @@ jobs:
           BASE_SHA: ${{ github.event.pull_request.base.sha }}
       # - name: Validate that changeset has necessary dependency updates
       #   run: |
-      #     npx changeset version
+      #     npx --package @changesets/cli -- changeset version
       #     npm update
       #     npm run check:dependencies
   check_package_versions:
@@ -845,7 +845,7 @@ jobs:
         with:
           node-version: 18
           cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
-      - run: npx changeset version
+      - run: npx --verbose --package @changesets/cli -- changeset version
       - run: npm run check:package-versions
 
   update_package_versions:

.husky/pre-push

@@ -1,2 +1,2 @@
-npx changeset status --since main
+npx --package @changesets/cli -- changeset status --since main
 npm run check:api

packages/platform-core/src/telemetry/telemetry_payload_exporter.test.ts

@@ -130,7 +130,7 @@ void describe('DefaultTelemetryPayloadExporter', () => {
     );
     assert.ok(validate(telemetryPayloadSent.identifiers.eventId));
     assert.ok(validate(telemetryPayloadSent.identifiers.localProjectId));
-    assert.ok(validate(telemetryPayloadSent.identifiers.accountId));
+    assert.ok(validate(telemetryPayloadSent.identifiers.accountId!));
     assert.strictEqual(telemetryPayloadSent.identifiers.awsRegion, 'us-east-1');
     assert.strictEqual(telemetryPayloadSent.event.state, 'SUCCEEDED');
     assert.deepStrictEqual(telemetryPayloadSent.event.command.path, [
@@ -205,7 +205,7 @@ void describe('DefaultTelemetryPayloadExporter', () => {
     );
     assert.ok(validate(telemetryPayloadSent.identifiers.eventId));
     assert.ok(validate(telemetryPayloadSent.identifiers.localProjectId));
-    assert.ok(validate(telemetryPayloadSent.identifiers.accountId));
+    assert.ok(validate(telemetryPayloadSent.identifiers.accountId!));
     assert.strictEqual(telemetryPayloadSent.identifiers.awsRegion, 'us-east-1');
     assert.strictEqual(telemetryPayloadSent.event.state, 'FAILED');
     assert.deepStrictEqual(telemetryPayloadSent.event.command.path, [
@@ -287,7 +287,7 @@ void describe('DefaultTelemetryPayloadExporter', () => {
     );
     assert.ok(validate(telemetryPayloadSent.identifiers.eventId));
     assert.ok(validate(telemetryPayloadSent.identifiers.localProjectId));
-    assert.ok(validate(telemetryPayloadSent.identifiers.accountId));
+    assert.ok(validate(telemetryPayloadSent.identifiers.accountId!));
     assert.strictEqual(telemetryPayloadSent.identifiers.awsRegion, 'us-east-1');
     assert.strictEqual(telemetryPayloadSent.event.state, 'FAILED');
     assert.deepStrictEqual(telemetryPayloadSent.event.command.path, []);

scripts/check_changeset_completeness.ts

@@ -50,7 +50,7 @@ const checkForMissingChangesets = async (
     throw new Error(
       `The following packages have changes but are not included in any changeset:${EOL}${EOL}${packagesMissingChangesets.join(
         EOL,
-      )}${EOL}${EOL}Add a changeset using 'npx changeset add'.`,
+      )}${EOL}${EOL}Add a changeset using 'npx --package @changesets/cli -- changeset add'.`,
     );
   }
 };

scripts/components/dependabot_version_update_handler.test.ts

@@ -87,7 +87,7 @@ void describe('dependabot version update handler', async () => {
     await setPackageDependencies(cantaloupePackagePath, { testDep: '^1.0.0' });
     await setPackageDependencies(platypusPackagePath, { testDep: '^1.0.0' });
 
-    await $`npx changeset init`;
+    await $`npx --package @changesets/cli -- changeset init`;
     await gitClient.commitAllChanges('Initial setup');
     baseRef = await gitClient.getHashForCurrentCommit();
   });

scripts/components/release_lifecycle.test.ts

@@ -104,7 +104,7 @@ void describe('release lifecycle', async () => {
 
     await npmClient.install(['@changesets/cli']);
 
-    await $`npx changeset init`;
+    await $`npx --package @changesets/cli -- changeset init`;
     await gitClient.commitAllChanges('Version Packages (baseline release)');
     await runPublishInTestDir();