-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): allow override of resendSignUpCode function call #6312
base: main
Are you sure you want to change the base?
feat(ui): allow override of resendSignUpCode function call #6312
Conversation
🦋 Changeset detectedLatest commit: 3ac8731 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ab9de0c
to
59e900a
Compare
59e900a
to
3ac8731
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me
@jordanvn Have we verified the |
@calebpollman I'm not sure if this is what you're referencing, but the Since the |
We were able to confirm that the interfaces include the new service override signature, however in smoke testing we discovered a small issue related to |
Upon further testing it was determined that the behavior identified within |
Description of changes
This adds the
resendSignUpCode
function to the list of function calls that can be overridden using ahandleResendSignUpCode
option on the services object. This is important for anyone who is modifying the username, which is actually what the current example in the documentation suggests.This PR also updates the documentation to match.
Issue #, if available
#4800
Description of how you validated changes
I have reviewed the existing tests for this component and found that they are currently skipped, making it hard to truly verify that these changes are functional. However, this change is quite simple and exactly follows the pattern of other function call overrides.
Checklist
yarn test
passes and tests are updated/addeddocs
,e2e
,examples
, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.