chore(docs): add StorageBrowser amplify auth note #6342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cshfang
approved these changes
Feb 10, 2025
dbanksdesign
approved these changes
Feb 10, 2025
AllanZhengYP
approved these changes
Feb 11, 2025
jordanvn
reviewed
Feb 11, 2025
| @@ -130,6 +130,7 @@ import "@aws-amplify/ui-react-storage/styles.css"; | |||
|
|
|||
| import config from './amplify_outputs.json'; | |||
|
|
|||
| // note: `Amplify.configure` must be run before call to `createAmplifyAuthAdapter` | |||
There was a problem hiding this comment.
Nit: should surrounding text in the Amplify Auth section of the docs further highlight this, or should this callout in the code be sufficient?
jordanvn
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Amplify.configurecall inStorageBrowserAmplifyAuthexampleStorageBrowserexample declaration from MockStorageBrowser.ts to StorageBrowser.ts to remove "Mock" references in documentationIssue #, if available
NA
Description of how you validated changes
yarn docs devChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.