From b136db1c1cb03eeb24cc47ec6af48a72a70457ce Mon Sep 17 00:00:00 2001
From: Andrew Rosa <dev@andrewhr.io>
Date: Wed, 18 May 2022 12:35:04 -0300
Subject: [PATCH] Include action on REST calls

This extra bit of information is useful in the context of telemetry,
specifically OpenTelemetry, as it allow us to adhere to [Semantic
Attributes for AWS][1].

To reduce coordination efforts, this change will only affect aws-elixir.
A further patch can address aws-erlang to achieve parity.

[1]: https://github.com/open-telemetry/opentelemetry-specification/blob/0a4c6656d1ac1261cfe426b964fd63b1c302877d/specification/trace/semantic_conventions/instrumentation/aws-sdk.md
---
 priv/rest.ex.eex          |  4 ++--
 test/aws_codegen_test.exs | 17 ++++++++++++++++-
 2 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/priv/rest.ex.eex b/priv/rest.ex.eex
index 083a185..2c6cf04 100644
--- a/priv/rest.ex.eex
+++ b/priv/rest.ex.eex
@@ -74,7 +74,7 @@ defmodule <%= context.module_name %> do
         metadata()
       <% end %>
 
-    Request.request_rest(client, meta, :get, url_path, query_params, headers, nil, options, <%= inspect(action.success_status_code) %>)<% else %>
+    Request.request_rest(client, meta, "<%= action.name %>", :get, url_path, query_params, headers, nil, options, <%= inspect(action.success_status_code) %>)<% else %>
   def <%= action.function_name %>(%Client{} = client<%= AWS.CodeGen.RestService.function_parameters(action) %>, input, options \\ []) do
     url_path = "<%= AWS.CodeGen.RestService.Action.url_path(action) %>"<%= if length(action.request_header_parameters) > 0 do %>
     {headers, input} =
@@ -118,6 +118,6 @@ defmodule <%= context.module_name %> do
         metadata()
       <% end %>
 
-    Request.request_rest(client, meta, <%= AWS.CodeGen.RestService.Action.method(action) %>, url_path, query_params, headers, input, options, <%= inspect(action.success_status_code) %>)<% end %>
+    Request.request_rest(client, meta, "<%= action.name %>", <%= AWS.CodeGen.RestService.Action.method(action) %>, url_path, query_params, headers, input, options, <%= inspect(action.success_status_code) %>)<% end %>
   end<% end %>
 end
diff --git a/test/aws_codegen_test.exs b/test/aws_codegen_test.exs
index c01083e..212e10b 100644
--- a/test/aws_codegen_test.exs
+++ b/test/aws_codegen_test.exs
@@ -94,6 +94,7 @@ defmodule AWS.CodeGenTest do
                    Request.request_rest(
                      client,
                      meta,
+                     \"PutEvents\",
                      :post,
                      url_path,
                      query_params,
@@ -169,6 +170,7 @@ defmodule AWS.CodeGenTest do
                    Request.request_rest(
                      client,
                      meta,
+                     \"PutEvents\",
                      :post,
                      url_path,
                      query_params,
@@ -249,6 +251,7 @@ defmodule AWS.CodeGenTest do
                    Request.request_rest(
                      client,
                      meta,
+                     \"PutEvents\",
                      :post,
                      url_path,
                      query_params,
@@ -345,7 +348,18 @@ defmodule AWS.CodeGenTest do
 
                    meta = metadata()
 
-                   Request.request_rest(client, meta, :get, url_path, query_params, headers, nil, options, 202)
+                   Request.request_rest(
+                     client,
+                     meta,
+                     \"PutEvents\",
+                     :get,
+                     url_path,
+                     query_params,
+                     headers,
+                     nil,
+                     options,
+                     202
+                   )
                  end
                end
                """)
@@ -405,6 +419,7 @@ defmodule AWS.CodeGenTest do
                    Request.request_rest(
                      client,
                      meta,
+                     \"PutEvents\",
                      :post,
                      url_path,
                      query_params,