Update to ACK runtime v0.28.0, code-generator v0.28.0 (#7)

### Update to ACK runtime `v0.28.0`, code-generator `v0.28.0`

----------

* ACK code-generator `v0.28.0` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.28.0)
* ACK runtime `v0.28.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.28.0)

----------

NOTE:
This PR increments the release version of service controller from `v0.0.2` to `v0.0.3`

Once this PR is merged, release `v0.0.3` will be automatically created for `cloudwatch-controller`

**Please close this PR, if you do not want the new patch release for `cloudwatch-controller`**

----------

#### stdout for `make build-controller`:

```
building ack-generate ... ok.
==== building cloudwatch-controller ====
Copying common custom resource definitions into cloudwatch
Building Kubernetes API objects for cloudwatch
Generating deepcopy code for cloudwatch
Generating custom resource definitions for cloudwatch
Building service controller for cloudwatch
Generating RBAC manifests for cloudwatch
Running gofmt against generated code for cloudwatch
Updating additional GitHub repository maintenance files
==== building cloudwatch-controller release artifacts ====
Building release artifacts for cloudwatch-v0.0.3
Generating common custom resource definitions
Generating custom resource definitions for cloudwatch
Generating RBAC manifests for cloudwatch
```

----------

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: ack-bot

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,11 +1,11 @@
 ack_generate_info:
-  build_date: "2023-08-04T16:51:02Z"
-  build_hash: e9b68590da73ce9143ba1e4361cebdc1d876c81e
-  go_version: go1.20.7
-  version: v0.26.1-7-ge9b6859-dirty
-api_directory_checksum: e21bfad36ac581912d611c9c390ab4bd2c2fb46d
+  build_date: "2023-12-14T21:33:50Z"
+  build_hash: 1f16813c807af6889060b4ce7ded2a69dc027d8c
+  go_version: go1.21.5
+  version: v0.28.0
+api_directory_checksum: 5a8c4d91df5604e5364afdecbc88814f06a8ab26
 api_version: v1alpha1
-aws_sdk_go_version: v1.44.303
+aws_sdk_go_version: v1.49.0
 generator_config_info:
   file_checksum: 2440ba630b0f66b3e92fd740afcafbd79da6b0c4
   original_file_name: generator.yaml

apis/v1alpha1/enums.go

@@ -29,14 +29,16 @@ spec:
         - "$(AWS_REGION)"
         - --aws-endpoint-url
         - "$(AWS_ENDPOINT_URL)"
-        - --enable-development-logging
-        - "$(ACK_ENABLE_DEVELOPMENT_LOGGING)"
+        - --enable-development-logging=$(ACK_ENABLE_DEVELOPMENT_LOGGING)
         - --log-level
         - "$(ACK_LOG_LEVEL)"
         - --resource-tags
         - "$(ACK_RESOURCE_TAGS)"
         - --watch-namespace
         - "$(ACK_WATCH_NAMESPACE)"
+        - --enable-leader-election=$(ENABLE_LEADER_ELECTION)
+        - --leader-election-namespace
+        - "$(LEADER_ELECTION_NAMESPACE)"
         image: controller:latest
         name: controller
         ports:
@@ -66,6 +68,10 @@ spec:
           value: "info"
         - name: ACK_RESOURCE_TAGS
           value: "services.k8s.aws/controller-version=%CONTROLLER_SERVICE%-%CONTROLLER_VERSION%,services.k8s.aws/namespace=%K8S_NAMESPACE%"
+        - name: ENABLE_LEADER_ELECTION
+          value: "false"
+        - name: LEADER_ELECTION_NAMESPACE
+          value: "ack-system"
         securityContext:
           allowPrivilegeEscalation: false
           privileged: false
@@ -79,5 +85,6 @@ spec:
       terminationGracePeriodSeconds: 10
       serviceAccountName: ack-cloudwatch-controller
       hostIPC: false
-      hostNetwork: false
       hostPID: false
+      hostNetwork: false
+      dnsPolicy: ClusterFirst

apis/v1alpha1/metric_alarm.go

@@ -6,4 +6,4 @@ kind: Kustomization
 images:
 - name: controller
   newName: public.ecr.aws/aws-controllers-k8s/cloudwatch-controller
-  newTag: 0.0.2
+  newTag: 0.0.3

cmd/controller/main.go

@@ -113,10 +113,17 @@ spec:
                 format: int64
                 type: integer
               extendedStatistic:
-                description: The percentile statistic for the metric specified in
-                  MetricName. Specify a value between p0.0 and p100. When you call
-                  PutMetricAlarm and specify a MetricName, you must specify either
-                  Statistic or ExtendedStatistic, but not both.
+                description: "The extended statistic for the metric specified in MetricName.
+                  When you call PutMetricAlarm and specify a MetricName, you must
+                  specify either Statistic or ExtendedStatistic but not both. \n If
+                  you specify ExtendedStatistic, the following are valid values: \n
+                  * p90 \n * tm90 \n * tc90 \n * ts90 \n * wm90 \n * IQM \n * PR(n:m)
+                  where n and m are values of the metric \n * TC(X%:X%) where X is
+                  between 10 and 90 inclusive. \n * TM(X%:X%) where X is between 10
+                  and 90 inclusive. \n * TS(X%:X%) where X is between 10 and 90 inclusive.
+                  \n * WM(X%:X%) where X is between 10 and 90 inclusive. \n For more
+                  information about these extended statistics, see CloudWatch statistics
+                  definitions (https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/Statistics-definitions.html)."
                 type: string
               insufficientDataActions:
                 description: "The actions to execute when this alarm transitions to
@@ -139,9 +146,9 @@ spec:
                 description: "The name for the metric associated with the alarm. For
                   each PutMetricAlarm operation, you must specify either MetricName
                   or a Metrics array. \n If you are creating an alarm based on a math
-                  expression, you cannot specify this parameter, or any of the Dimensions,
-                  Period, Namespace, Statistic, or ExtendedStatistic parameters. Instead,
-                  you specify all this information in the Metrics array."
+                  expression, you cannot specify this parameter, or any of the Namespace,
+                  Dimensions, Period, Unit, Statistic, or ExtendedStatistic parameters.
+                  Instead, you specify all this information in the Metrics array."
                 type: string
               metrics:
                 description: "An array of MetricDataQuery structures that enable you
@@ -152,11 +159,11 @@ spec:
                   array is the expression that the alarm watches. You designate this
                   expression by setting ReturnData to true for this object in the
                   array. For more information, see MetricDataQuery (https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_MetricDataQuery.html).
-                  \n If you use the Metrics parameter, you cannot include the MetricName,
-                  Dimensions, Period, Namespace, Statistic, or ExtendedStatistic parameters
-                  of PutMetricAlarm in the same operation. Instead, you retrieve the
-                  metrics you are using in your math expression as part of the Metrics
-                  array."
+                  \n If you use the Metrics parameter, you cannot include the Namespace,
+                  MetricName, Dimensions, Period, Unit, Statistic, or ExtendedStatistic
+                  parameters of PutMetricAlarm in the same operation. Instead, you
+                  retrieve the metrics you are using in your math expression as part
+                  of the Metrics array."
                 items:
                   description: "This structure is used in both GetMetricData and PutMetricAlarm.
                     The supported use of this structure is different for those two
@@ -290,13 +297,15 @@ spec:
                 type: string
               tags:
                 description: "A list of key-value pairs to associate with the alarm.
-                  You can associate as many as 50 tags with an alarm. \n Tags can
-                  help you organize and categorize your resources. You can also use
-                  them to scope user permissions by granting a user permission to
-                  access or change only resources with certain tag values. \n If you
-                  are using this operation to update an existing alarm, any tags you
-                  specify in this parameter are ignored. To change the tags of an
-                  existing alarm, use TagResource (https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_TagResource.html)
+                  You can associate as many as 50 tags with an alarm. To be able to
+                  associate tags with the alarm when you create the alarm, you must
+                  have the cloudwatch:TagResource permission. \n Tags can help you
+                  organize and categorize your resources. You can also use them to
+                  scope user permissions by granting a user permission to access or
+                  change only resources with certain tag values. \n If you are using
+                  this operation to update an existing alarm, any tags you specify
+                  in this parameter are ignored. To change the tags of an existing
+                  alarm, use TagResource (https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_TagResource.html)
                   or UntagResource (https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_UntagResource.html)."
                 items:
                   description: A key-value pair associated with a CloudWatch resource.
@@ -337,16 +346,18 @@ spec:
                   all network interfaces. You can also specify a unit when you create
                   a custom metric. Units help provide conceptual meaning to your data.
                   Metric data points that specify a unit of measure, such as Percent,
-                  are aggregated separately. \n If you don't specify Unit, CloudWatch
-                  retrieves all unit types that have been published for the metric
-                  and attempts to evaluate the alarm. Usually, metrics are published
-                  with only one unit, so the alarm works as intended. \n However,
-                  if the metric is published with multiple types of units and you
-                  don't specify a unit, the alarm's behavior is not defined and it
-                  behaves unpredictably. \n We recommend omitting Unit so that you
-                  don't inadvertently specify an incorrect unit that is not published
-                  for this metric. Doing so causes the alarm to be stuck in the INSUFFICIENT
-                  DATA state."
+                  are aggregated separately. If you are creating an alarm based on
+                  a metric math expression, you can specify the unit for each metric
+                  (if needed) within the objects in the Metrics array. \n If you don't
+                  specify Unit, CloudWatch retrieves all unit types that have been
+                  published for the metric and attempts to evaluate the alarm. Usually,
+                  metrics are published with only one unit, so the alarm works as
+                  intended. \n However, if the metric is published with multiple types
+                  of units and you don't specify a unit, the alarm's behavior is not
+                  defined and it behaves unpredictably. \n We recommend omitting Unit
+                  so that you don't inadvertently specify an incorrect unit that is
+                  not published for this metric. Doing so causes the alarm to be stuck
+                  in the INSUFFICIENT DATA state."
                 type: string
             required:
             - comparisonOperator

config/controller/deployment.yaml

@@ -4,4 +4,5 @@ resources:
 - role-reader.yaml
 - role-writer.yaml
 - service-account.yaml
-
+- leader-election-role.yaml
+- leader-election-role-binding.yaml

config/controller/kustomization.yaml

@@ -0,0 +1,14 @@
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: RoleBinding
+metadata:
+  namespace: ack-system
+  name: cloudwatch-leader-election-rolebinding
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: Role
+  name: cloudwatch-leader-election-role
+subjects:
+- kind: ServiceAccount
+  name: ack-cloudwatch-controller
+  namespace: ack-system

config/crd/bases/cloudwatch.services.k8s.aws_metricalarms.yaml

@@ -0,0 +1,26 @@
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: Role
+metadata:
+  name: cloudwatch-leader-election-role
+  namespace: ack-system
+rules:
+- apiGroups:
+  - coordination.k8s.io
+  resources:
+  - leases
+  verbs:
+  - get
+  - list
+  - watch
+  - create
+  - update
+  - patch
+  - delete
+- apiGroups:
+  - ""
+  resources:
+  - events
+  verbs:
+  - create
+  - patch