Skip to content

Commit b74b3b4

Browse files
authored
improv(logger): resolve issue when no logger region is set (#4319)
1 parent 5aff398 commit b74b3b4

File tree

2 files changed

+45
-0
lines changed

2 files changed

+45
-0
lines changed

packages/logger/src/Logger.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1362,6 +1362,7 @@ class Logger extends Utility implements LoggerInterface {
13621362
this.addToPowertoolsLogData({
13631363
awsRegion: getStringFromEnv({
13641364
key: 'AWS_REGION',
1365+
defaultValue: '',
13651366
}),
13661367
environment:
13671368
environment ||
Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
import { Logger } from '../../src/Logger.js';
2+
import { describe, it, expect, vi, afterEach } from 'vitest';
3+
4+
describe('Logger PowertoolsLogData environment variables', () => {
5+
afterEach(() => {
6+
vi.unstubAllEnvs();
7+
});
8+
9+
it.each([
10+
[undefined, ''],
11+
['us-west-2', 'us-west-2'],
12+
])('sets awsRegion to %s when AWS_REGION env var is %s', (envValue, expected) => {
13+
// Prepare
14+
vi.stubEnv('AWS_REGION', envValue);
15+
// Act
16+
const logger = new Logger();
17+
// Assess
18+
expect(logger['powertoolsLogData'].awsRegion).toBe(expected);
19+
});
20+
21+
it.each([
22+
[undefined, ''],
23+
['prd', 'prd'],
24+
])('sets environment to %s when ENVIRONMENT env var is %s', (envValue, expected) => {
25+
// Prepare
26+
vi.stubEnv('ENVIRONMENT', envValue);
27+
// Act
28+
const logger = new Logger();
29+
// Assess
30+
expect(logger['powertoolsLogData'].environment).toBe(expected);
31+
});
32+
33+
it.each([
34+
[undefined, 'service_undefined'],
35+
['my-service', 'my-service'],
36+
])('sets serviceName to %s when POWERTOOLS_SERVICE_NAME env var is %s', (envValue, expected) => {
37+
// Prepare
38+
vi.stubEnv('POWERTOOLS_SERVICE_NAME', envValue);
39+
// Act
40+
const logger = new Logger();
41+
// Assess
42+
expect(logger['powertoolsLogData'].serviceName).toBe(expected);
43+
});
44+
});

0 commit comments

Comments
 (0)