Skip to content
This repository was archived by the owner on Oct 4, 2024. It is now read-only.

GHELicense description needs to note that it cant begin with a forward slash #18

Open
ju2wheels opened this issue Nov 7, 2018 · 0 comments

Comments

@ju2wheels
Copy link

ju2wheels commented Nov 7, 2018

https://github.com/aws-quickstart/quickstart-github-enterprise/blob/develop/templates/quickstart-github-enterprise-master.template#L144-L147
https://github.com/aws-quickstart/quickstart-github-enterprise/blob/develop/templates/quickstart-github-enterprise.template#L273-L276

GHELicense is like QSS3KeyPrefix and should note that it cannot start with a forward slash because that is already added by the aws s3 cp in the scripts/.

The description should also be clarified to note that its the location from where the install will look for the license and not where the install process will upload it to (you have to upload it there yourself). The description is a bit confusing as to the usage of the parameter (e.g. that is the location read from and not a location written to).

One of the issues that can cause #7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant