Go1.24 bump + fixing non-constant format string issue (#1623)

Author: Paramadon

Makefile

@@ -158,7 +158,7 @@ install-addlicense:
 install-golangci-lint:
 	#Install from source for golangci-lint is not recommended based on https://golangci-lint.run/usage/install/#install-from-source so using binary
 	#installation
-	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(TOOLS_BIN_DIR) v1.62.2
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(TOOLS_BIN_DIR) v1.64.2
 
 fmt: install-goimports addlicense
 	go fmt ./...

cmd/config-downloader/downloader.go

@@ -132,13 +132,13 @@ func main() {
 	util.SetSSLEnv(cc.SSLMap())
 	var errorMessage string
 	if downloadLocation == "" || outputDir == "" {
-		executable, err := os.Executable()
-		if err == nil {
-			errorMessage = fmt.Sprintf("E! usage: " + filepath.Base(executable) + " --output-dir <path> --download-source ssm:<parameter-store-name> ")
+		var errorMessage string
+		if executable, err := os.Executable(); err == nil {
+			errorMessage = "E! usage: " + filepath.Base(executable) + " --output-dir <path> --download-source ssm:<parameter-store-name>"
 		} else {
-			errorMessage = fmt.Sprintf("E! usage: --output-dir <path> --download-source ssm:<parameter-store-name> ")
+			errorMessage = "E! usage: --output-dir <path> --download-source ssm:<parameter-store-name>"
 		}
-		log.Panicf(errorMessage)
+		log.Panic(errorMessage)
 	}
 
 	mode = sdkutil.DetectAgentMode(mode)
@@ -153,7 +153,7 @@ func main() {
 			errorMessage = "E! Please make sure the credentials and region set correctly on your hosts.\n" +
 				"Refer to http://docs.aws.amazon.com/cli/latest/userguide/cli-chap-getting-started.html"
 		}
-		log.Panicf(errorMessage)
+		log.Panic(errorMessage)
 	}
 
 	// clean up output dir for tmp files before writing out new tmp file.

go.mod

@@ -1,6 +1,6 @@
 module github.com/aws/amazon-cloudwatch-agent
 
-go 1.23.6
+go 1.24.2
 
 replace github.com/influxdata/telegraf => github.com/aws/telegraf v0.10.2-0.20250113150713-a2dfaa4cdf6d
 

plugins/inputs/logfile/fileconfig.go

@@ -114,7 +114,7 @@ func (config *FileConfig) init() error {
 		if config.Enc, _ = charset.Lookup(config.Encoding); config.Enc == nil {
 			if config.Enc, _ = ianaindex.IANA.Encoding(config.Encoding); config.Enc == nil {
 				msg := fmt.Sprintf("E! the encoding %s is not supported.", config.Encoding)
-				log.Printf(msg)
+				log.Print(msg)
 				return errors.New(msg)
 			}
 		}

plugins/inputs/statsd/graphite/parser.go

@@ -151,7 +151,7 @@ func (p *GraphiteParser) Parse(buf []byte) ([]telegraf.Metric, error) {
 	}
 
 	if errStr != "" {
-		return metrics, fmt.Errorf(strings.TrimSpace(errStr))
+		return metrics, fmt.Errorf("%s", strings.TrimSpace(errStr))
 	}
 	return metrics, nil
 }

receiver/awsebsnvmereceiver/internal/nvme/ebs_metrics_notunix.go

@@ -7,6 +7,6 @@ package nvme
 
 import "errors"
 
-func GetMetrics(devicePath string) (EBSMetrics, error) {
+func GetMetrics(_ string) (EBSMetrics, error) {
 	return EBSMetrics{}, errors.New("ebs metrics not supported")
 }

receiver/awsebsnvmereceiver/internal/nvme/util_notunix.go

@@ -11,18 +11,18 @@ func (u *Util) GetAllDevices() ([]DeviceFileAttributes, error) {
 	return nil, errors.New("nvme not supported")
 }
 
-func (u *Util) GetDeviceSerial(device *DeviceFileAttributes) (string, error) {
+func (u *Util) GetDeviceSerial(_ *DeviceFileAttributes) (string, error) {
 	return "", errors.New("nvme not supported")
 }
 
-func (u *Util) GetDeviceModel(device *DeviceFileAttributes) (string, error) {
+func (u *Util) GetDeviceModel(_ *DeviceFileAttributes) (string, error) {
 	return "", errors.New("nvme not supported")
 }
 
-func (u *Util) IsEbsDevice(device *DeviceFileAttributes) (bool, error) {
+func (u *Util) IsEbsDevice(_ *DeviceFileAttributes) (bool, error) {
 	return false, errors.New("nvme not supported")
 }
 
-func (u *Util) DevicePath(device string) (string, error) {
+func (u *Util) DevicePath(_ string) (string, error) {
 	return "", errors.New("nvme not supported")
 }

translator/translate/logs/metrics_collected/prometheus/ruleConfigPath.go

@@ -21,7 +21,7 @@ type ConfigPath struct {
 func (obj *ConfigPath) ApplyRule(input interface{}) (string, interface{}) {
 	configPath, err := util.GetConfigPath(prometheusConfigName, common.PrometheusConfigPathKey, defaultLinuxPath+prometheusConfigName, input)
 	if err != nil {
-		log.Panicf(err.Error())
+		log.Panic(err.Error())
 	}
 	return common.PrometheusConfigPathKey, configPath
 }