Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolkit-helpers: formatSecurityDiff ignores nested templates #293

Open
1 task
kaizencc opened this issue Mar 28, 2025 · 0 comments
Open
1 task

toolkit-helpers: formatSecurityDiff ignores nested templates #293

kaizencc opened this issue Mar 28, 2025 · 0 comments

Comments

@kaizencc
Copy link
Contributor

Describe the bug

In the DiffFormatter, we have options to formatSecurityDiff and formatStackDiff. For the stack diff, nestedStackTemplates can be provided via property and this becomes part of the stack diff:

const nextDiff = this.formatStackDiffHelper(
        nestedStack.deployedTemplate,
        nestedStack.physicalName ?? nestedStackLogicalId,
        nestedStack.nestedStackTemplates,
        options,
      );

For the security diff, this isn't considered at all, so it will always ignore nested stacks and only diff on the root stack.

We need to consider nested stacks for the security diff as well.

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

n/a

Current Behavior

n/a

Reproduction Steps

n/a

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.1006.0

Framework Version

No response

Node.js Version

Node 20

OS

MacOS

Language

TypeScript

Language Version

No response

Other information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants