[Agent 1.1.2] COE AI to fix unzip fallback to ruby unzip util

Why is this change needed?
---------
Prior to this change, customers had issue with fallback to ruby unzip util, because there were
partially unzipped files and ruby unzip didn't override them.

How does it address the issue?
---------
This change will rescue any exit code other than 0 and use override parameter set to true,
so it would not throw Zip::DestinationFileExistsError during ruby unzip

Author: Anandaraju Coimbatore Sivaraju

lib/instance_agent/platform/linux_util.rb

@@ -133,22 +133,12 @@ def self.execute_zip_command(cmd)
       log(:debug, "Command status: #{$?}")
       log(:debug, "Command output: #{output}")
 
-      if !validZipExitStatus(exit_status)
+      if exit_status != 0
         msg = "Error extracting zip archive: #{exit_status}"
         log(:error, msg)
         raise msg
       end
     end
-
-    private
-    def self.validZipExitStatus(exit_status)
-      exit_status == 0 || isWarningStatus(exit_status)
-    end
-
-    private
-    def self.isWarningStatus(exit_status)
-      exit_status == 1
-    end
 
     private
     def self.log(severity, message)

lib/instance_agent/plugins/codedeploy/command_executor.rb

@@ -384,17 +384,16 @@ def unpack_bundle(cmd, bundle_file, deployment_spec)
             begin
               InstanceAgent::Platform.util.extract_zip(bundle_file, dst)
             rescue
+              log(:warn, "Encountered non-zero exit code with default system unzip util. Hence falling back to ruby unzip to mitigate any partially unzipped or skipped zip files.")
               Zip::File.open(bundle_file) do |zipfile|
                 zipfile.each do |f|
                   file_dst = File.join(dst, f.name)
                   FileUtils.mkdir_p(File.dirname(file_dst))
-                  zipfile.extract(f, file_dst)
+                  zipfile.extract(f, file_dst) { true }
                 end
               end
             end
           else
-            # If the bundle was a generated through a Sabini Repository
-            # it will be in tar format, and it won't have a bundle type
             InstanceAgent::Platform.util.extract_tar(bundle_file, dst)
           end