Generate a normal copy when installing a symlink of a directory #199
+90
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for solving this issue! This affects us at @Spendesk and we currently need to resort to recreating the symlinks manually in an AfterInstall hooks. Is there something that's preventing the fix from being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152.
Summary
This PR makes the installer checks each file if it is a symlink of a directory, and generates
normal_copyinstead ofdirectory_copy.Description of changes:
When the installer(
lib/instance_agent/plugins/codedeploy/installer.rb) runs, it generates instructions for copying source files to the deploy destination. The installer recursively generatesmkdirfor directory files andcopyinstructions for regular files.The problem occurs when a src file is a symlink of a directory. Although the symlink itself IS a regular file,
File.directory?(dir_symlink)still returnstrue. SinceDir.entries(dir_symlink)also works as if it is a normal directory, children files of the symlink are copied instead of the symlink itself.This PR adds a symlink check as well as a directory check when generating instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.