Skip to content

Commit 3b70eb1

Browse files
Alex Wangwangyb-A
authored andcommitted
fix(sdk): fix timestamp format for checkpoint
- fix timestamp for execution succeed and fail
1 parent 1756a56 commit 3b70eb1

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/aws_durable_execution_sdk_python/lambda_service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,7 @@ def create_context_fail(
495495
def create_execution_succeed(cls, payload: str) -> OperationUpdate:
496496
"""Create an instance of OperationUpdate for type: EXECUTION, action: SUCCEED."""
497497
return cls(
498-
operation_id=f"execution-result-{datetime.datetime.now(tz=datetime.UTC)}",
498+
operation_id=f"execution-result-{int(datetime.datetime.now(tz=datetime.UTC).timestamp() * 1000)}",
499499
operation_type=OperationType.EXECUTION,
500500
action=OperationAction.SUCCEED,
501501
payload=payload,
@@ -505,7 +505,7 @@ def create_execution_succeed(cls, payload: str) -> OperationUpdate:
505505
def create_execution_fail(cls, error: ErrorObject) -> OperationUpdate:
506506
"""Create an instance of OperationUpdate for type: EXECUTION, action: FAIL."""
507507
return cls(
508-
operation_id=f"execution-result-{datetime.datetime.now(tz=datetime.UTC)}",
508+
operation_id=f"execution-result-{int(datetime.datetime.now(tz=datetime.UTC).timestamp() * 1000)}",
509509
operation_type=OperationType.EXECUTION,
510510
action=OperationAction.FAIL,
511511
error=error,

tests/lambda_service_test.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -686,9 +686,12 @@ def test_operation_update_create_wait_start():
686686
@patch("aws_durable_execution_sdk_python.lambda_service.datetime")
687687
def test_operation_update_create_execution_succeed(mock_datetime):
688688
"""Test OperationUpdate.create_execution_succeed factory method."""
689-
mock_datetime.datetime.now.return_value = "2023-01-01"
689+
690+
mock_datetime.datetime.now.return_value = datetime.datetime.fromtimestamp(
691+
1672531200.0, tz=datetime.UTC
692+
)
690693
update = OperationUpdate.create_execution_succeed("success_payload")
691-
assert update.operation_id == "execution-result-2023-01-01"
694+
assert update.operation_id == "execution-result-1672531200000"
692695
assert update.operation_type == OperationType.EXECUTION
693696
assert update.action == OperationAction.SUCCEED
694697
assert update.payload == "success_payload"

0 commit comments

Comments
 (0)