fix reviews on awschunking and default behavior

Author: kai-ion

tests/aws-cpp-sdk-core-tests/utils/stream/AwsChunkedStreamTest.cpp

@@ -122,8 +122,8 @@ TEST_F(AwsChunkedStreamTest, ShouldWorkOnEmptyStream) {
 TEST_F(AwsChunkedStreamTest, ChunkingInterceptorShouldWork) {
   auto request = CreateRequestWithChecksum("www.elda.com/will", "1234567890123456789012345");
   std::shared_ptr<IOStream> inputStream = Aws::MakeShared<StringStream>(TEST_LOG_TAG, "1234567890123456789012345");
-  auto chunkedBuf = Aws::MakeUnique<smithy::client::features::AwsChunkedStreamBuf>(TEST_LOG_TAG, &request, inputStream, 10);
-  Aws::IOStream chunkedStream(chunkedBuf.release());
+  auto chunkedBuf = Aws::MakeShared<smithy::client::features::AwsChunkedStreamBuf>(TEST_LOG_TAG, &request, inputStream, 10);
+  Aws::IOStream chunkedStream(chunkedBuf.get());
   const auto encodedStr = ReadEntireStream(chunkedStream);
   auto expectedStreamWithChecksum = "A\r\n1234567890\r\nA\r\n1234567890\r\n5\r\n12345\r\n0\r\nx-amz-checksum-crc32:78DeVw==\r\n\r\n";
   EXPECT_EQ(expectedStreamWithChecksum, encodedStr);
@@ -132,8 +132,8 @@ TEST_F(AwsChunkedStreamTest, ChunkingInterceptorShouldWork) {
 TEST_F(AwsChunkedStreamTest, ChunkingInterceptorShouldNotRequireTwoReadsOnSmallChunk) {
   auto request = CreateRequestWithChecksum("www.clemar.com/strohl", "12345");
   std::shared_ptr<IOStream> inputStream = Aws::MakeShared<StringStream>(TEST_LOG_TAG, "12345");
-  auto chunkedBuf = Aws::MakeUnique<smithy::client::features::AwsChunkedStreamBuf>(TEST_LOG_TAG, &request, inputStream, 100);
-  Aws::IOStream chunkedStream(chunkedBuf.release());
+  auto chunkedBuf = Aws::MakeShared<smithy::client::features::AwsChunkedStreamBuf>(TEST_LOG_TAG, &request, inputStream, 100);
+  Aws::IOStream chunkedStream(chunkedBuf.get());
   const auto encodedStr = ReadEntireStream(chunkedStream);
   auto expectedStreamWithChecksum = "5\r\n12345\r\n0\r\nx-amz-checksum-crc32:y/U6HA==\r\n\r\n";
   EXPECT_EQ(expectedStreamWithChecksum, encodedStr);
@@ -142,8 +142,8 @@ TEST_F(AwsChunkedStreamTest, ChunkingInterceptorShouldNotRequireTwoReadsOnSmallC
 TEST_F(AwsChunkedStreamTest, ChunkingInterceptorShouldWorkOnSmallBuffer) {
   auto request = CreateRequestWithChecksum("www.eugief.com/hesimay", "1234567890");
   std::shared_ptr<IOStream> inputStream = Aws::MakeShared<StringStream>(TEST_LOG_TAG, "1234567890");
-  auto chunkedBuf = Aws::MakeUnique<smithy::client::features::AwsChunkedStreamBuf>(TEST_LOG_TAG, &request, inputStream, 5);
-  Aws::IOStream chunkedStream(chunkedBuf.release());
+  auto chunkedBuf = Aws::MakeShared<smithy::client::features::AwsChunkedStreamBuf>(TEST_LOG_TAG, &request, inputStream, 5);
+  Aws::IOStream chunkedStream(chunkedBuf.get());
   char buffer[10];
   chunkedStream.read(buffer, sizeof(buffer));
   std::string firstRead(buffer, chunkedStream.gcount());
@@ -159,8 +159,8 @@ TEST_F(AwsChunkedStreamTest, ChunkingInterceptorShouldWorkOnSmallBuffer) {
 TEST_F(AwsChunkedStreamTest, ChunkingInterceptorShouldWorkOnEmptyStream) {
   auto request = CreateRequestWithChecksum("www.nidia.com/juna", "");
   std::shared_ptr<IOStream> inputStream = Aws::MakeShared<StringStream>(TEST_LOG_TAG, "");
-  auto chunkedBuf = Aws::MakeUnique<smithy::client::features::AwsChunkedStreamBuf>(TEST_LOG_TAG, &request, inputStream, 5);
-  Aws::IOStream chunkedStream(chunkedBuf.release());
+  auto chunkedBuf = Aws::MakeShared<smithy::client::features::AwsChunkedStreamBuf>(TEST_LOG_TAG, &request, inputStream, 5);
+  Aws::IOStream chunkedStream(chunkedBuf.get());
   const auto encodedStr = ReadEntireStream(chunkedStream);
   EXPECT_EQ("0\r\nx-amz-checksum-crc32:AAAAAA==\r\n\r\n", encodedStr);
 }