fix reviews on awschunking and default behavior

Author: kai-ion

src/aws-cpp-sdk-core/include/smithy/client/features/ChunkingInterceptor.h

@@ -147,10 +147,10 @@ class ChunkingInterceptor : public smithy::interceptor::Interceptor {
             }
         }
 
-        auto chunkedBuf = Aws::MakeShared<AwsChunkedStreamBuf>(
+        auto chunkedBuf = Aws::MakeUnique<AwsChunkedStreamBuf>(
             ALLOCATION_TAG, request.get(), originalBody);
         auto chunkedBody = std::shared_ptr<Aws::IOStream>(
-            new Aws::IOStream(chunkedBuf.get()));
+            new Aws::IOStream(chunkedBuf.release()));
 
         request->AddContentBody(chunkedBody);
         return request;

tests/aws-cpp-sdk-core-tests/utils/stream/AwsChunkedStreamTest.cpp

@@ -5,37 +5,16 @@
 #include <aws/core/http/standard/StandardHttpRequest.h>
 #include <aws/core/utils/crypto/CRC32.h>
 #include <aws/core/utils/stream/AwsChunkedStream.h>
-#include <smithy/client/features/ChunkingInterceptor.h>
 #include <aws/testing/AwsCppSdkGTestSuite.h>
 
 using namespace Aws;
 using namespace Aws::Http::Standard;
 using namespace Aws::Utils::Stream;
 using namespace Aws::Utils::Crypto;
 
-const char* TEST_LOG_TAG = "AWS_CHUNKED_STREAM_TEST";
+class AwsChunkedStreamTest : public Aws::Testing::AwsCppSdkGTestSuite {};
 
-class AwsChunkedStreamTest : public Aws::Testing::AwsCppSdkGTestSuite {
-protected:
-    StandardHttpRequest CreateRequestWithChecksum(const std::string& url, const std::string& /* data */) {
-        StandardHttpRequest request{Http::URI(Aws::String(url.c_str())), Http::HttpMethod::HTTP_GET};
-        auto requestHash = Aws::MakeShared<CRC32>(TEST_LOG_TAG);
-        request.SetRequestHash("crc32", requestHash);
-        return request;
-    }
-    
-    std::string ReadEntireStream(Aws::IOStream& stream) {
-        Aws::StringStream output;
-        char buffer[100];
-        while (stream.read(buffer, sizeof(buffer))) {
-            output.write(buffer, stream.gcount());
-        }
-        if (stream.gcount() > 0) {
-            output.write(buffer, stream.gcount());
-        }
-        return output.str().c_str();
-    }
-};
+const char* TEST_LOG_TAG = "AWS_CHUNKED_STREAM_TEST";
 
 TEST_F(AwsChunkedStreamTest, ChunkedStreamShouldWork) {
   StandardHttpRequest request{"www.elda.com/will", Http::HttpMethod::HTTP_GET};
@@ -118,49 +97,3 @@ TEST_F(AwsChunkedStreamTest, ShouldWorkOnEmptyStream) {
   auto encodedStr = firstRead.str();
   EXPECT_EQ("0\r\nx-amz-checksum-crc32:AAAAAA==\r\n\r\n", encodedStr);
 }
-
-TEST_F(AwsChunkedStreamTest, ChunkingInterceptorShouldWork) {
-  auto request = CreateRequestWithChecksum("www.elda.com/will", "1234567890123456789012345");
-  std::shared_ptr<IOStream> inputStream = Aws::MakeShared<StringStream>(TEST_LOG_TAG, "1234567890123456789012345");
-  auto chunkedBuf = Aws::MakeShared<smithy::client::features::AwsChunkedStreamBuf>(TEST_LOG_TAG, &request, inputStream, 10);
-  Aws::IOStream chunkedStream(chunkedBuf.get());
-  const auto encodedStr = ReadEntireStream(chunkedStream);
-  auto expectedStreamWithChecksum = "A\r\n1234567890\r\nA\r\n1234567890\r\n5\r\n12345\r\n0\r\nx-amz-checksum-crc32:78DeVw==\r\n\r\n";
-  EXPECT_EQ(expectedStreamWithChecksum, encodedStr);
-}
-
-TEST_F(AwsChunkedStreamTest, ChunkingInterceptorShouldNotRequireTwoReadsOnSmallChunk) {
-  auto request = CreateRequestWithChecksum("www.clemar.com/strohl", "12345");
-  std::shared_ptr<IOStream> inputStream = Aws::MakeShared<StringStream>(TEST_LOG_TAG, "12345");
-  auto chunkedBuf = Aws::MakeShared<smithy::client::features::AwsChunkedStreamBuf>(TEST_LOG_TAG, &request, inputStream, 100);
-  Aws::IOStream chunkedStream(chunkedBuf.get());
-  const auto encodedStr = ReadEntireStream(chunkedStream);
-  auto expectedStreamWithChecksum = "5\r\n12345\r\n0\r\nx-amz-checksum-crc32:y/U6HA==\r\n\r\n";
-  EXPECT_EQ(expectedStreamWithChecksum, encodedStr);
-}
-
-TEST_F(AwsChunkedStreamTest, ChunkingInterceptorShouldWorkOnSmallBuffer) {
-  auto request = CreateRequestWithChecksum("www.eugief.com/hesimay", "1234567890");
-  std::shared_ptr<IOStream> inputStream = Aws::MakeShared<StringStream>(TEST_LOG_TAG, "1234567890");
-  auto chunkedBuf = Aws::MakeShared<smithy::client::features::AwsChunkedStreamBuf>(TEST_LOG_TAG, &request, inputStream, 5);
-  Aws::IOStream chunkedStream(chunkedBuf.get());
-  char buffer[10];
-  chunkedStream.read(buffer, sizeof(buffer));
-  std::string firstRead(buffer, chunkedStream.gcount());
-  EXPECT_EQ("5\r\n12345\r\n", firstRead);
-  char buffer2[50];
-  chunkedStream.read(buffer2, sizeof(buffer2));
-  std::string secondRead(buffer2, chunkedStream.gcount());
-  EXPECT_EQ("5\r\n67890\r\n0\r\nx-amz-checksum-crc32:Jh2u5Q==\r\n\r\n", secondRead);
-  chunkedStream.read(buffer, sizeof(buffer));
-  EXPECT_EQ(0, chunkedStream.gcount());
-}
-
-TEST_F(AwsChunkedStreamTest, ChunkingInterceptorShouldWorkOnEmptyStream) {
-  auto request = CreateRequestWithChecksum("www.nidia.com/juna", "");
-  std::shared_ptr<IOStream> inputStream = Aws::MakeShared<StringStream>(TEST_LOG_TAG, "");
-  auto chunkedBuf = Aws::MakeShared<smithy::client::features::AwsChunkedStreamBuf>(TEST_LOG_TAG, &request, inputStream, 5);
-  Aws::IOStream chunkedStream(chunkedBuf.get());
-  const auto encodedStr = ReadEntireStream(chunkedStream);
-  EXPECT_EQ("0\r\nx-amz-checksum-crc32:AAAAAA==\r\n\r\n", encodedStr);
-}