Revert "added sensitive data redaction for powershell host"

This reverts commit c70630c.

Author: afroz429

generator/AWSPSGeneratorLib/FormatConfig/ConfigModel.cs

@@ -71,7 +71,7 @@ internal HashSet<string> TypeInclusionSet
         }
 
         /// <summary>
-        /// Specific types to exclude from the emitted formats. This list will be
+        /// Specific types to exlude from the emitted formats. This list will be
         /// automatically extended to include any types found in custom format files.
         /// </summary>
         [XmlArray]
@@ -245,21 +245,16 @@ public class ColumnConfig
         public HeaderAlignment HeaderAlignment { get; set; }
         [XmlAttribute]
         public int HeaderOrder { get; set; }
-        [XmlIgnore]
-        public bool IsSensitive { get; set; }
 
         [XmlAttribute]
         public string ScriptBlock { get; set; }
         [XmlAttribute]
         public string PropertyName { get; set; }
 
-
-
         public ColumnConfig()
         {
             ScriptBlock = null;
             PropertyName = null;
-            IsSensitive = false;
 
             HeaderLabel = null;
             HeaderWidth = 0;
@@ -273,7 +268,6 @@ public void Merge(ColumnConfig other)
             HeaderWidth = other.HeaderWidth != 0 ? other.HeaderWidth : this.HeaderWidth;
             HeaderAlignment = other.HeaderAlignment != HeaderAlignment.None ? other.HeaderAlignment : this.HeaderAlignment;
             HeaderOrder = other.HeaderOrder != 0 ? other.HeaderOrder : this.HeaderOrder;
-            IsSensitive = other.IsSensitive || this.IsSensitive;
 
             ScriptBlock = other.ScriptBlock ?? this.ScriptBlock;
             PropertyName = other.PropertyName ?? this.PropertyName;

generator/AWSPSGeneratorLib/Generators/FormatGenerator.cs

@@ -32,8 +32,6 @@ public class FormatGenerator : Generator
         private ConfigModelCollection ConfigCollection { get; set; }
 
         private const string AwsToolsPrefix = "AWS.Tools.";
-
-        private const string SensitiveDataRedactionMessage = "*** sensitive data redacted from host ***";
         #endregion
 
 
@@ -177,8 +175,7 @@ private void GenerateView(ConfigModel config, XmlWriter writer, Type type)
                     existingColumn.Merge(new ColumnConfig
                     {
                         HeaderLabel = name,
-                        PropertyName = name,
-                        IsSensitive = property.IsSensitive()
+                        PropertyName = name
                     });
 
                     newConfig.Columns.Add(existingColumn);
@@ -325,16 +322,7 @@ private void GenerateView_NonReflective(ConfigModel config, XmlWriter writer, Ty
                                 {
                                     writer.WriteStartElement(isTableView ? "TableColumnItem" : "ListItem");
                                     {
-                                        if (column.IsSensitive)
-                                        {
-                                            if (!isTableView)
-                                                writer.WriteElementString("Label", column.PropertyName);
-
-                                            string scriptBlockValue =
-                                                $"if((Test-Path variable:AWSPowerShell_Show_Sensitive_Data) -and $false.Equals((Get-Variable AWSPowerShell_Show_Sensitive_Data).Value)){{'{SensitiveDataRedactionMessage}'}} else{{$_.{column.PropertyName}}}";
-                                            writer.WriteElementString("ScriptBlock", scriptBlockValue);
-                                        }
-                                        else if (!string.IsNullOrEmpty(column.PropertyName))
+                                        if (!string.IsNullOrEmpty(column.PropertyName))
                                             writer.WriteElementString("PropertyName", column.PropertyName);
                                         else if (!string.IsNullOrEmpty(column.ScriptBlock))
                                             writer.WriteElementString("ScriptBlock", column.ScriptBlock);

generator/AWSPSGeneratorLib/Utils/Extensions.cs

@@ -4,7 +4,6 @@
 using System.Text;
 using System.Xml.Serialization;
 using System.IO;
-using System.Reflection;
 
 namespace AWSPowerShellGenerator.Utils
 {
@@ -46,27 +45,5 @@ public static string GetTypeFullCodeName(this Type t)
 
             return typeName + "<" + args + ">";
         }
-
-        public static bool IsSensitive(this PropertyInfo propertyInfo)
-        {
-            dynamic awsPropertyAttribute = propertyInfo
-                .GetCustomAttributes().SingleOrDefault(attribute => attribute.GetType().FullName == "Amazon.Runtime.Internal.AWSPropertyAttribute");
-
-            return awsPropertyAttribute != null && awsPropertyAttribute.Sensitive;
-        }
-
-        /// <summary>
-        /// Checks if the type contains any sensitive data by going recursively over all the internal properties
-        /// </summary>
-        public static bool ContainsSensitiveData(this Type type, HashSet<Type> visitedTypes = null)
-        {
-            visitedTypes ??= [];
-
-            if (!visitedTypes.Add(type)) 
-                return false;
-
-            return type.GetProperties().Any(childProperty => IsSensitive(childProperty) || ContainsSensitiveData(childProperty.PropertyType, visitedTypes));
-        }
-
     }
 }

modules/AWSPowerShell/Common/CommonCmdlets.cs

@@ -526,80 +526,4 @@ protected override void ProcessRecord()
             }
         }
     }
-
-    /// <summary>
-    /// Controls the display of sensitive information in the PowerShell console output.
-    /// When set to false (default), sensitive data is masked in the console display.
-    /// When set to true, sensitive data is shown in plain text.
-    /// Note: This setting only affects console display - stored variables retain the original unmasked data regardless of this setting.
-    /// This cmdlet sets a shell variable AWSPowerShell_Show_Sensitive_Data using the scope.
-    /// </summary>
-    [Cmdlet("Set", "AWSSensitiveDataConfiguration")]
-    [AWSCmdlet("Controls the display of sensitive information in the PowerShell console output. When set to true, sensitive data is shown in plain text in the console output.")]
-    [OutputType("None")]
-    public class SetAWSSensitiveDataConfigurationCmdlet : PSCmdlet
-    {
-        #region Parameter ShowSensitiveData
-
-        /// <summary>
-        /// Controls whether sensitive data appears in PowerShell console output.
-        /// When set to true, displays un-redacted sensitive data in the console.
-        /// When set to false (default), automatically masks sensitive data in console output.
-        /// </summary>
-        [Parameter(ValueFromPipelineByPropertyName = true, Mandatory = true)]
-        public bool ShowSensitiveData { get; set; }
-
-        #endregion
-
-        #region Parameter Scope
-        /// <summary>
-        /// <para>
-        /// Sets the scope of the shell variable AWSPowerShell_Show_Sensitive_Data.
-        /// For details about variables scopes, see https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_scopes.
-        /// </para>
-        /// </summary>
-        [Parameter(ValueFromPipelineByPropertyName = true)]
-        public VariableScope Scope { get; set; }
-        #endregion
-
-        protected override void ProcessRecord()
-        {
-            base.ProcessRecord();
-            WriteVerbose($"Setting AWSShowSensitiveData to {ShowSensitiveData}");
-            string scope = MyInvocation.BoundParameters.ContainsKey("Scope") ? Scope.ToString() + ":" : "";
-
-            this.SessionState.PSVariable.Set(scope+ SessionKeys.AWSShowSensitiveData, ShowSensitiveData);
-        }
-    }
-
-    /// <summary>
-    /// Returns the current configuration value that controls how sensitive data is displayed in the PowerShell console.
-    /// This cmdlet returns a Boolean value indicating whether sensitive data is shown or redacted in console output.
-    /// </summary>
-    [Cmdlet("Get", "AWSSensitiveDataConfiguration")]
-    [AWSCmdlet("Gets the current configuration settings for sensitive data display in PowerShell output.")]
-    [OutputType("PSObject")]
-    public class GetAWSSensitiveDataConfigurationCmdlet : PSCmdlet
-    {
-        protected override void ProcessRecord()
-        {
-            base.ProcessRecord();
-            var showSensitiveData = this.SessionState.PSVariable.Get(SessionKeys.AWSShowSensitiveData);
-            var result = new PSObject();
-            
-            // in v4 default ShowSensitiveData is true
-            const bool defaultShowSensitiveData = true;
-
-            var noteProperty = new PSNoteProperty("ShowSensitiveData", defaultShowSensitiveData);
-            
-            if (showSensitiveData != null)
-            {
-                noteProperty.Value = (bool)showSensitiveData.Value;
-                
-            }
-
-            result.Properties.Add(noteProperty);
-            WriteObject(result);
-        }
-    }
 }

modules/AWSPowerShell/Common/CredentialsArguments.cs

@@ -799,7 +799,6 @@ internal static class SessionKeys
         public const string AWSCredentialsVariableName = "StoredAWSCredentials";
         public const string AWSRegionVariableName = "StoredAWSRegion";
         public const string AWSCallHistoryName = "AWSHistory";
-        public const string AWSShowSensitiveData = "AWSPowerShell_Show_Sensitive_Data";
         public const string AWSProxyVariableName = "AWSProxy";
     }