Skip to content

Remove all TLS provider from s2n_quic when default feature is false #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taikulawo opened this issue Mar 26, 2025 · 0 comments
Open

Remove all TLS provider from s2n_quic when default feature is false #2567

taikulawo opened this issue Mar 26, 2025 · 0 comments
Labels
bug Something isn't working priority/low Rank 4 size/small

Comments

@taikulawo
Copy link
Contributor

Problem:

We create own TLS provider, so we don't want bundle additional TLS stack s2n_quic has.

s2n-quic = { version = "1.55.0", default-features = false, features = [
    "provider-address-token-default",
], 

s2n_quic enter fallback code, cause compile error.

error[E0412]: cannot find type `Server` in module `default`
  --> /root/.cargo/git/checkouts/s2n-quic-f7936126449d7979/a9aa1c2/quic/s2n-quic/src/provider/tls.rs:46:28
   |
46 |     type Server = default::Server;
   |                            ^^^^^^ not found in `default`
   |
help: consider importing this struct through its public re-export
   |
6  + use crate::Server;
   |
help: if you import `Server`, refer to it directly
   |
46 -     type Server = default::Server;
46 +     type Server = Server;
   |

error[E0412]: cannot find type `Client` in module `default`

Solution:

Can we wrap in feature control block?

#[cfg(feature = "provider-tls-default")]
impl Provider for foo{}

Requirements / Acceptance Criteria:

Out of scope:

@maddeleine maddeleine added the bug Something isn't working label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/low Rank 4 size/small
Projects
None yet
Development

No branches or pull requests

3 participants