Skip to content

Commit 366dbc8

Browse files
committed
drop 3.6, add 3.9 and 3.10
1 parent 7e19e52 commit 366dbc8

File tree

5 files changed

+29
-28
lines changed

5 files changed

+29
-28
lines changed

.github/workflows/test_release.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,6 @@ jobs:
3636
runs-on: ubuntu-latest
3737
steps:
3838
- uses: actions/checkout@v1
39-
- name: Setup Python 3.6
40-
uses: actions/setup-python@v1
41-
with:
42-
python-version: 3.6
4339
- name: Setup Python 3.7
4440
uses: actions/setup-python@v1
4541
with:
@@ -48,6 +44,10 @@ jobs:
4844
uses: actions/setup-python@v1
4945
with:
5046
python-version: 3.8
47+
- name: Setup Python 3.9
48+
uses: actions/setup-python@v1
49+
with:
50+
python-version: 3.9
5151
- name: Install Dependencies
5252
run: pip install tox
5353
# runs unit tests for each python version
@@ -58,7 +58,7 @@ jobs:
5858
- name: Integration Tests
5959
# pull requests are untrusted and do not have access to secrets needed for integ tests
6060
if: github.event_name != 'pull_request'
61-
run: tox -e py36 -- tests/integ
61+
run: tox -e py39 -- tests/integ
6262
env:
6363
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
6464
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

CONTRIBUTING.md

+19-18
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,21 @@ information to effectively respond to your bug report or contribution.
88

99
## Table of Contents
1010

11-
* [Table of Contents](#table-of-contents)
12-
* [Reporting Bugs/Feature Requests](#reporting-bugsfeature-requests)
13-
* [Contributing via Pull Requests (PRs)](#contributing-via-pull-requests-prs)
14-
* [Setting up Your Development Environment *[Optional, but Recommended]*](#setting-up-your-development-environment-optional-but-recommended)
15-
* [Pulling Down the Code](#pulling-down-the-code)
16-
* [Running the Unit Tests](#running-the-unit-tests)
17-
* [Running the Integration Tests](#running-the-integration-tests)
18-
* [Making and Testing Your Change](#making-and-testing-your-change)
19-
* [Committing Your Change](#committing-your-change)
20-
* [Sending a Pull Request](#sending-a-pull-request)
21-
* [Finding Contributions to Work On](#finding-contributions-to-work-on)
22-
* [Code of Conduct](#code-of-conduct)
23-
* [Security Issue Notifications](#security-issue-notifications)
24-
* [Licensing](#licensing)
11+
- [Contributing Guidelines](#contributing-guidelines)
12+
- [Table of Contents](#table-of-contents)
13+
- [Reporting Bugs/Feature Requests](#reporting-bugsfeature-requests)
14+
- [Contributing via Pull Requests](#contributing-via-pull-requests)
15+
- [Setting Up Your Development Environment](#setting-up-your-development-environment)
16+
- [Pulling Down the Code](#pulling-down-the-code)
17+
- [Running the Unit Tests](#running-the-unit-tests)
18+
- [Running the Integration Tests](#running-the-integration-tests)
19+
- [Making and Testing Your Change](#making-and-testing-your-change)
20+
- [Sending a Pull Request](#sending-a-pull-request)
21+
- [Committing Your Change](#committing-your-change)
22+
- [Finding contributions to work on](#finding-contributions-to-work-on)
23+
- [Code of Conduct](#code-of-conduct)
24+
- [Security issue notifications](#security-issue-notifications)
25+
- [Licensing](#licensing)
2526

2627
## Reporting Bugs/Feature Requests
2728

@@ -72,19 +73,19 @@ GitHub provides additional document on [forking a repository](https://help.githu
7273
1. cd into the sagemaker-experiments folder: `cd sagemaker-experiments` or `cd /environment/sagemaker-experiments`
7374
1. Run the following tox command and verify that all code checks and unit tests pass: `tox -- tests/unit`
7475

75-
You can also run a single test with the following command: `tox -e py36 -- -s -vv <path_to_file><file_name>::<test_function_name>`
76+
You can also run a single test with the following command: `tox -e py39 -- -s -vv <path_to_file><file_name>::<test_function_name>`
7677
* Note that the coverage test will fail if you only run a single test, so make sure to surround the command with `export IGNORE_COVERAGE=-` and `unset IGNORE_COVERAGE`
77-
* Example: `export IGNORE_COVERAGE=- ; tox -e py36 -- -s -vv tests/unit/test_experiment.py::test_processing_job_environment ; unset IGNORE_COVERAGE`
78+
* Example: `export IGNORE_COVERAGE=- ; tox -e py39 -- -s -vv tests/unit/test_experiment.py::test_processing_job_environment ; unset IGNORE_COVERAGE`
7879

7980
### Running the Integration Tests
8081

8182
Our CI system runs integration tests (the ones in the `tests/integ` directory), in parallel, for every Pull Request.
8283
You should only worry about manually running any new integration tests that you write, or integration tests that test an area of code that you've modified.
8384

8485
1. Follow the instructions at [Set Up the AWS Command Line Interface (AWS CLI)](https://docs.aws.amazon.com/polly/latest/dg/setup-aws-cli.html).
85-
1. To run a test, specify the test file and method you want to run per the following command: `tox -e py36 -- -s -vv <path_to_file><file_name>::<test_function_name>`
86+
1. To run a test, specify the test file and method you want to run per the following command: `tox -e py39 -- -s -vv <path_to_file><file_name>::<test_function_name>`
8687
* Note that the coverage test will fail if you only run a single test, so make sure to surround the command with `export IGNORE_COVERAGE=-` and `unset IGNORE_COVERAGE`
87-
* Example: `export IGNORE_COVERAGE=- ; tox -e py36 -- -s -vv tests/integ/test_tf_script_mode.py::test_mnist ; unset IGNORE_COVERAGE`
88+
* Example: `export IGNORE_COVERAGE=- ; tox -e py39 -- -s -vv tests/integ/test_tf_script_mode.py::test_mnist ; unset IGNORE_COVERAGE`
8889
1. optionally run slow tests `tox -e slow-tests`
8990

9091
### Making and Testing Your Change

README.rst

+3-3
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ To run the integration tests, the following prerequisites must be met:
199199

200200
.. code-block:: bash
201201
202-
tox -e py37 -- --region cn-north-1
202+
tox -e py39 -- --region cn-north-1
203203
204204
**Docker Based Integration Tests**
205205

@@ -229,10 +229,10 @@ Docker Setup
229229
.. code-block:: bash
230230
231231
# run only docker based tests
232-
tox -e py38 -- tests/integ -m 'docker'
232+
tox -e py39 -- tests/integ -m 'docker'
233233
234234
# exclude docker based tests
235-
tox -e py38 -- tests/integ -m 'not docker'
235+
tox -e py39 -- tests/integ -m 'not docker'
236236
237237
238238

setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ def read(fname):
5252
"Natural Language :: English",
5353
"License :: OSI Approved :: Apache Software License",
5454
"Programming Language :: Python",
55-
"Programming Language :: Python :: 3.6",
5655
"Programming Language :: Python :: 3.7",
5756
"Programming Language :: Python :: 3.8",
57+
"Programming Language :: Python :: 3.9",
5858
],
5959
setup_requires=["setuptools_scm", "setuptools"],
6060
install_requires=required_packages,

tox.ini

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[tox]
2-
envlist = py{36,37,38}
2+
envlist = py{37,38,39}
33

44
skip_missing_interpreters = False
55
ignore_basepython_conflict = True

0 commit comments

Comments
 (0)