Linter upgrade and fixes

Author: Javy de Koning

.github/workflows/mega-linter.yml

@@ -27,7 +27,7 @@ jobs:
 
       - name: MegaLinter
         id: ml
-        uses: oxsecurity/megalinter@v8.1.0
+        uses: oxsecurity/megalinter@v8.4.2
         env:
           # All available variables are described in documentation
           # https://megalinter.io/configuration/

docs/installation-guide.md

@@ -92,6 +92,7 @@ Please note that building on *Windows* is not supported, please use the
     This should return a table that is possibly empty.
   - Additionally, running `docker --version` should return version 19 or
     later.
+<!-- markdown-link-check-disable-next-line -->
 - [make](https://www.gnu.org/software/make/)
   - To test if it is available, run `make --version`.
     This should return 4.3 or later.
@@ -101,6 +102,7 @@ Please note that building on *Windows* is not supported, please use the
 - [jq](https://github.com/jqlang/jq)
   - To test if it is available, run `jq --version`.
     This version should be 1.6 or later.
+<!-- markdown-link-check-disable-next-line -->
 - [sed](https://www.gnu.org/software/sed/)
   - To test if it is available, run `sed --version`.
     This should return 4.3 or later.

samples/sample-service-catalog-product/productX/template.yml

@@ -47,6 +47,11 @@ Parameters:
 Resources:
   Cloud9Instance:
     Type: AWS::Cloud9::EnvironmentEC2
+    Metadata:
+      cfn-lint:
+        config:
+          ignore_checks:
+            - E1152
     Properties:
       AutomaticStopTimeMinutes: !Ref AutomaticStopTimeInMinutes
       Description: !Ref InstanceDescription