Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BOM to version catalog #1440

Closed
1 task
cloudshiftchris opened this issue Oct 11, 2024 · 3 comments · Fixed by #1470
Closed
1 task

Add BOM to version catalog #1440

cloudshiftchris opened this issue Oct 11, 2024 · 3 comments · Fixed by #1470
Labels
feature-request A feature should be added or improved.

Comments

@cloudshiftchris
Copy link

Describe the feature

atm the bom is not part of the SDK-published version catalog. When using the BOM with the version catalog you have to specify the SDK version twice - once for the BOM, and again for the version catalog.

    implementation(platform(libs.awssdk.kotlin.bom))  // from libs.versions.toml
    implementation(awssdk.services.codeartifact) // from SDK version catalog
    implementation(awssdk.services.ecr)
    implementation(awssdk.services.s3)
    implementation(awssdk.services.ssm)
    implementation(awssdk.services.rds)
    implementation(awssdk.services.resourcegroupstaggingapi)
    implementation(awssdk.services.route53)
    implementation(awssdk.services.dynamodb)
    implementation(awssdk.services.secretsmanager)
    implementation(awssdk.runtime.smithy.kotlin.http.client.engine.okhttp)

Is your feature request related to a problem?

While this doesn't appear to pose any material issue having the SDK version in two places is at best confusing. The BOM will trump whatever the version catalog specifies.

Proposed Solution

Add the BOM to the version catalog, e.g. awssdk.bom

Describe alternative solutions or features you've considered

The sample above shows the workaround of specifying the BOM separately

Acknowledge

  • I may be able to implement this feature request

AWS SDK for Kotlin version

1.3.51

Platform (JVM/JS/Native)

JVM

Operating system and version

MacOS

@cloudshiftchris cloudshiftchris added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 11, 2024
@ianbotsf ianbotsf removed the needs-triage This issue or PR still needs to be triaged. label Oct 14, 2024
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@lauzadis
Copy link
Member

Hi @cloudshiftchris, the BOM should be available in the version catalog after today's release. Thanks again for the great feature requests

@cloudshiftchris
Copy link
Author

Amazing, thanks @lauzadis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants