Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance smoke test debuggability by adding --stacktrace flag to inner Gradle runner #1515

Merged
merged 1 commit into from
Jan 29, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ import aws.sdk.kotlin.codegen.smoketests.AWS_SERVICE_FILTER
import aws.sdk.kotlin.codegen.smoketests.AWS_SKIP_TAGS
import org.gradle.testkit.runner.GradleRunner
import java.io.File
import kotlin.test.*
import kotlin.test.Test
import kotlin.test.assertContains

class SmokeTestE2ETest {
@Test
Expand Down Expand Up @@ -65,8 +66,11 @@ private fun runSmokeTests(

val task = GradleRunner.create()
.withProjectDir(File(sdkRootDir))
// FIXME: Remove `-Paws.kotlin.native=false` when Kotlin Native is ready
.withArguments("-Paws.kotlin.native=false", ":tests:codegen:smoke-tests:services:$service:smokeTest")
.withArguments(
"--stacktrace", // Make sure unexpected errors are debuggable
"-Paws.kotlin.native=false", // FIXME: Remove `-Paws.kotlin.native=false` when Kotlin Native is ready
":tests:codegen:smoke-tests:services:$service:smokeTest",
)
.withEnvironment(envVars)

val buildResult = if (expectingFailure) task.buildAndFail() else task.build()
Expand Down
Loading